Merge branch 'fix-gitlab-employee-attribute' into 'master'

Move Gitlab Employee badge to internal discussion api

Closes #211847

See merge request gitlab-org/gitlab!27525

app/serializers/note_user_entity.rb

 # frozen_string_literal: true
 
 class NoteUserEntity < UserEntity
+  expose :gitlab_employee?, as: :is_gitlab_employee, if: ->(user, options) { ::Feature.enabled?(:gitlab_employee_badge) && user.gitlab_employee? }
+
   unexpose :web_url
 end

lib/api/entities/discussion.rb

@@ -5,7 +5,7 @@ module API
     class Discussion < Grape::Entity
       expose :id
       expose :individual_note?, as: :individual_note
-      expose :notes, using: Entities::NoteWithGitlabEmployeeBadge
+      expose :notes, using: Entities::Note
     end
   end
 end

lib/api/entities/note_with_gitlab_employee_badge.rb

-# frozen_string_literal: true
-
-module API
-  module Entities
-    class NoteWithGitlabEmployeeBadge < Note
-      expose :author, using: Entities::UserWithGitlabEmployeeBadge
-      expose :resolved_by, using: Entities::UserWithGitlabEmployeeBadge, if: ->(note, options) { note.resolvable? }
-    end
-  end
-end

lib/api/entities/user_with_gitlab_employee_badge.rb

-# frozen_string_literal: true
-
-module API
-  module Entities
-    class UserWithGitlabEmployeeBadge < UserBasic
-      expose :gitlab_employee?, as: :is_gitlab_employee, if: ->(user, options) { ::Feature.enabled?(:gitlab_employee_badge) && user.gitlab_employee? }
-    end
-  end
-end

spec/controllers/projects/issues_controller_spec.rb

@@ -1390,6 +1390,61 @@ describe Projects::IssuesController do
         expect(note_json['author']['status_tooltip_html']).to be_present
       end
 
+      context 'is_gitlab_employee attribute' do
+        subject { get :discussions, params: { namespace_id: project.namespace, project_id: project, id: issue.iid } }
+
+        before do
+          allow(Gitlab).to receive(:com?).and_return(true)
+          note_user = discussion.author
+          note_user.update(email: email)
+          note_user.confirm
+        end
+
+        shared_examples 'non inclusion of gitlab employee badge' do
+          it 'does not render the is_gitlab_employee attribute' do
+            subject
+
+            note_json = json_response.first['notes'].first
+
+            expect(note_json['author']['is_gitlab_employee']).to be nil
+          end
+        end
+
+        context 'when user is a gitlab employee' do
+          let(:email) { 'test@gitlab.com' }
+
+          it 'renders the is_gitlab_employee attribute' do
+            subject
+
+            note_json = json_response.first['notes'].first
+
+            expect(note_json['author']['is_gitlab_employee']).to be true
+          end
+
+          context 'when feature flag is disabled' do
+            before do
+              stub_feature_flags(gitlab_employee_badge: false)
+            end
+
+            it_behaves_like 'non inclusion of gitlab employee badge'
+          end
+        end
+
+        context 'when user is not a gitlab employee' do
+          let(:email) { 'test@example.com' }
+
+          it_behaves_like 'non inclusion of gitlab employee badge'
+
+          context 'when feature flag is disabled' do
+            before do
+              stub_feature_flags(gitlab_employee_badge: false)
+            end
+
+            it_behaves_like 'non inclusion of gitlab employee badge'
+          end
+        end
+      end
+
       it 'does not cause an extra query for the status' do
         control = ActiveRecord::QueryRecorder.new do
           get :discussions, params: { namespace_id: project.namespace, project_id: project, id: issue.iid }

spec/fixtures/api/schemas/entities/user.json

@@ -17,8 +17,7 @@
     "path": { "type": "string" },
     "name": { "type": "string" },
     "username": { "type": "string" },
-    "status_tooltip_html": { "$ref": "../types/nullable_string.json" },
-    "is_gitlab_employee": { "type": "boolean" }
+    "status_tooltip_html": { "$ref": "../types/nullable_string.json" }
   },
   "additionalProperties": false
 }

spec/support/shared_examples/requests/api/discussions_shared_examples.rb

@@ -55,58 +55,6 @@ RSpec.shared_examples 'with cross-reference system notes' do
 end
 
 RSpec.shared_examples 'discussions API' do |parent_type, noteable_type, id_name, can_reply_to_individual_notes: false|
-  shared_examples 'is_gitlab_employee attribute presence' do
-    subject { get api("/#{parent_type}/#{parent.id}/#{noteable_type}/#{noteable[id_name]}/discussions", user) }
-
-    before do
-      allow(Gitlab).to receive(:com?).and_return(true)
-      user.update(email: email)
-      user.confirm
-    end
-
-    context 'when author is a gitlab employee' do
-      let(:email) { 'test@gitlab.com' }
-
-      it 'returns is_gitlab_employee as true' do
-        subject
-
-        expect(json_response.first["notes"].first["author"]['is_gitlab_employee']).to be true
-      end
-    end
-
-    shared_examples 'non inclusion of gitlab employee badge' do
-      it 'does not include is_gitlab_employee attribute' do
-        subject
-
-        expect(json_response.first["notes"].first["author"]).not_to have_key('is_gitlab_employee')
-      end
-    end
-
-    context 'when author is not a gitlab employee' do
-      let(:email) { 'test@example.com' }
-
-      it_behaves_like 'non inclusion of gitlab employee badge'
-    end
-
-    describe 'when feature flag is disabled' do
-      before do
-        stub_feature_flags(gitlab_employee_badge: false)
-      end
-
-      context 'when author is a gitlab employee' do
-        let(:email) { 'test@gitlab.com' }
-
-        it_behaves_like 'non inclusion of gitlab employee badge'
-      end
-
-      context 'when author is not a gitlab employee' do
-        let(:email) { 'test@example.com' }
-
-        it_behaves_like 'non inclusion of gitlab employee badge'
-      end
-    end
-  end
-
   describe "GET /#{parent_type}/:id/#{noteable_type}/:noteable_id/discussions" do
     it "returns an array of discussions" do
       get api("/#{parent_type}/#{parent.id}/#{noteable_type}/#{noteable[id_name]}/discussions", user)
@@ -130,8 +78,6 @@ RSpec.shared_examples 'discussions API' do |parent_type, noteable_type, id_name,
 
       expect(response).to have_gitlab_http_status(:not_found)
     end
-
-    it_behaves_like 'is_gitlab_employee attribute presence'
   end
 
   describe "GET /#{parent_type}/:id/#{noteable_type}/:noteable_id/discussions/:discussion_id" do
@@ -250,8 +196,6 @@ RSpec.shared_examples 'discussions API' do |parent_type, noteable_type, id_name,
         end
       end
     end
-
-    it_behaves_like 'is_gitlab_employee attribute presence'
   end
 
   describe "POST /#{parent_type}/:id/#{noteable_type}/:noteable_id/discussions/:discussion_id/notes" do