Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ceea2c10
Commit
ceea2c10
authored
Jan 24, 2021
by
Takuya Noguchi
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Replace OpenSSL constants with strings
Signed-off-by:
Takuya Noguchi
<
takninnovationresearch@gmail.com
>
parent
062788e5
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
8 additions
and
3 deletions
+8
-3
ee/changelogs/unreleased/Lint-DeprecatedOpenSSLConstant-ee.yml
...angelogs/unreleased/Lint-DeprecatedOpenSSLConstant-ee.yml
+5
-0
ee/lib/gitlab/geo/oauth/logout_state.rb
ee/lib/gitlab/geo/oauth/logout_state.rb
+1
-1
ee/spec/lib/gitlab/geo/oauth/logout_state_spec.rb
ee/spec/lib/gitlab/geo/oauth/logout_state_spec.rb
+2
-2
No files found.
ee/changelogs/unreleased/Lint-DeprecatedOpenSSLConstant-ee.yml
0 → 100644
View file @
ceea2c10
---
title
:
Replace OpenSSL constants with strings
merge_request
:
52431
author
:
Takuya Noguchi
type
:
other
ee/lib/gitlab/geo/oauth/logout_state.rb
View file @
ceea2c10
...
...
@@ -64,7 +64,7 @@ module Gitlab
end
def
with_cipher
(
auth_tag
=
nil
)
cipher
=
OpenSSL
::
Cipher
::
AES256
.
new
(
:GCM
)
cipher
=
OpenSSL
::
Cipher
.
new
(
'AES-256-GCM'
)
yield
cipher
...
...
ee/spec/lib/gitlab/geo/oauth/logout_state_spec.rb
View file @
ceea2c10
...
...
@@ -22,7 +22,7 @@ RSpec.describe Gitlab::Geo::Oauth::LogoutState do
end
it
'returns nil when encryption fails'
do
allow_next_instance_of
(
OpenSSL
::
Cipher
::
AES256
)
do
|
instance
|
allow_next_instance_of
(
OpenSSL
::
Cipher
)
do
|
instance
|
allow
(
instance
).
to
receive
(
:final
)
{
raise
OpenSSL
::
OpenSSLError
}
end
...
...
@@ -78,7 +78,7 @@ RSpec.describe Gitlab::Geo::Oauth::LogoutState do
end
it
'returns nil when decryption fails'
do
allow_next_instance_of
(
OpenSSL
::
Cipher
::
AES256
)
do
|
instance
|
allow_next_instance_of
(
OpenSSL
::
Cipher
)
do
|
instance
|
allow
(
instance
).
to
receive
(
:final
)
{
raise
OpenSSL
::
OpenSSLError
}
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment