Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
cf9515de
Commit
cf9515de
authored
Dec 23, 2021
by
Igor Drozdov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove find_tag_via_gitaly feature flag
Changelog: changed
parent
029d4eea
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
1 addition
and
20 deletions
+1
-20
app/models/repository.rb
app/models/repository.rb
+1
-1
config/feature_flags/development/find_tag_via_gitaly.yml
config/feature_flags/development/find_tag_via_gitaly.yml
+0
-8
spec/models/repository_spec.rb
spec/models/repository_spec.rb
+0
-11
No files found.
app/models/repository.rb
View file @
cf9515de
...
...
@@ -191,7 +191,7 @@ class Repository
end
def
find_tag
(
name
)
if
@tags
.
blank?
&&
Feature
.
enabled?
(
:find_tag_via_gitaly
,
project
,
default_enabled: :yaml
)
if
@tags
.
blank?
raw_repository
.
find_tag
(
name
)
else
tags
.
find
{
|
tag
|
tag
.
name
==
name
}
...
...
config/feature_flags/development/find_tag_via_gitaly.yml
deleted
100644 → 0
View file @
029d4eea
---
name
:
find_tag_via_gitaly
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/70181
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/340899
milestone
:
'
14.3'
type
:
development
group
:
group::source code
default_enabled
:
true
spec/models/repository_spec.rb
View file @
cf9515de
...
...
@@ -2398,17 +2398,6 @@ RSpec.describe Repository do
it
'returns nil when tag does not exists'
do
expect
(
repository
.
find_tag
(
'does-not-exist'
)).
to
be_nil
end
context
'when find_tag_via_gitaly is disabled'
do
it
'fetches all tags'
do
stub_feature_flags
(
find_tag_via_gitaly:
false
)
expect
(
Gitlab
::
GitalyClient
)
.
to
receive
(
:call
).
with
(
anything
,
:ref_service
,
:find_all_tags
,
anything
,
anything
).
and_call_original
expect
(
repository
.
find_tag
(
'v1.1.0'
).
name
).
to
eq
(
'v1.1.0'
)
end
end
end
describe
'#avatar'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment