Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
d15d8261
Commit
d15d8261
authored
Jul 07, 2021
by
mfluharty
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Limit popover max width, trigger on hover
parent
6bbf1dcb
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
4 deletions
+4
-4
ee/app/assets/javascripts/diffs/components/code_quality_gutter_icon.vue
...javascripts/diffs/components/code_quality_gutter_icon.vue
+2
-2
ee/spec/frontend/diffs/components/code_quality_gutter_icon_spec.js
...rontend/diffs/components/code_quality_gutter_icon_spec.js
+2
-2
No files found.
ee/app/assets/javascripts/diffs/components/code_quality_gutter_icon.vue
View file @
d15d8261
...
@@ -63,9 +63,9 @@ export default {
...
@@ -63,9 +63,9 @@ export default {
class="gl-hover-cursor-pointer codequality-severity-icon"
class="gl-hover-cursor-pointer codequality-severity-icon"
/>
/>
<gl-popover
<gl-popover
triggers=
"
click blur
"
triggers=
"
hover focus
"
placement=
"topright"
placement=
"topright"
:css-classes=
"['gl-max-w-
none
', 'gl-w-half']"
:css-classes=
"['gl-max-w-
max-content
', 'gl-w-half']"
:target=
"`codequality-$
{filePath}:${line}`"
:target=
"`codequality-$
{filePath}:${line}`"
:title="$options.i18n.popoverTitle"
:title="$options.i18n.popoverTitle"
>
>
...
...
ee/spec/frontend/diffs/components/code_quality_gutter_icon_spec.js
View file @
d15d8261
...
@@ -73,10 +73,10 @@ describe('EE CodeQualityGutterIcon', () => {
...
@@ -73,10 +73,10 @@ describe('EE CodeQualityGutterIcon', () => {
createComponent
();
createComponent
();
});
});
it
(
'
opens a popover on click
'
,
()
=>
{
it
(
'
shows a popover on hover
'
,
()
=>
{
const
popoverTarget
=
'
codequality-index.js:3
'
;
const
popoverTarget
=
'
codequality-index.js:3
'
;
wrapper
.
findComponent
(
GlIcon
).
trigger
(
'
click
'
);
wrapper
.
findComponent
(
GlIcon
).
trigger
(
'
mouseover
'
);
expect
(
wrapper
.
find
(
GlPopover
).
props
().
target
).
toBe
(
popoverTarget
);
expect
(
wrapper
.
find
(
GlPopover
).
props
().
target
).
toBe
(
popoverTarget
);
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment