Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
d2873c49
Commit
d2873c49
authored
Mar 04, 2019
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix EE differences in parallel_diff_view.vue
Closes
https://gitlab.com/gitlab-org/gitlab-ee/issues/10007
parent
1711e104
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
6 deletions
+10
-6
app/assets/javascripts/diffs/components/parallel_diff_view.vue
...ssets/javascripts/diffs/components/parallel_diff_view.vue
+4
-5
app/assets/javascripts/diffs/mixins/draft_comments.js
app/assets/javascripts/diffs/mixins/draft_comments.js
+1
-0
ee/app/assets/javascripts/diffs/mixins/draft_comments.js
ee/app/assets/javascripts/diffs/mixins/draft_comments.js
+5
-1
No files found.
app/assets/javascripts/diffs/components/parallel_diff_view.vue
View file @
d2873c49
<
script
>
<
script
>
import
{
mapGetters
}
from
'
vuex
'
;
import
{
mapGetters
}
from
'
vuex
'
;
import
draftCommentsMixin
from
'
ee_else_ce/diffs/mixins/draft_comments
'
;
import
parallelDiffTableRow
from
'
./parallel_diff_table_row.vue
'
;
import
parallelDiffTableRow
from
'
./parallel_diff_table_row.vue
'
;
import
parallelDiffCommentRow
from
'
./parallel_diff_comment_row.vue
'
;
import
parallelDiffCommentRow
from
'
./parallel_diff_comment_row.vue
'
;
// eslint-disable-next-line import/order
import
ParallelDraftCommentRow
from
'
ee/batch_comments/components/parallel_draft_comment_row.vue
'
;
export
default
{
export
default
{
components
:
{
components
:
{
parallelDiffTableRow
,
parallelDiffTableRow
,
parallelDiffCommentRow
,
parallelDiffCommentRow
,
ParallelDraftCommentRow
,
ParallelDraftCommentRow
:
()
=>
import
(
'
ee_component/batch_comments/components/parallel_draft_comment_row.vue
'
),
},
},
mixins
:
[
draftCommentsMixin
],
props
:
{
props
:
{
diffFile
:
{
diffFile
:
{
type
:
Object
,
type
:
Object
,
...
@@ -29,7 +29,6 @@ export default {
...
@@ -29,7 +29,6 @@ export default {
},
},
computed
:
{
computed
:
{
...
mapGetters
(
'
diffs
'
,
[
'
commitId
'
]),
...
mapGetters
(
'
diffs
'
,
[
'
commitId
'
]),
...
mapGetters
(
'
batchComments
'
,
[
'
shouldRenderParallelDraftRow
'
,
'
draftForLine
'
]),
diffLinesLength
()
{
diffLinesLength
()
{
return
this
.
diffLines
.
length
;
return
this
.
diffLines
.
length
;
},
},
...
...
app/assets/javascripts/diffs/mixins/draft_comments.js
View file @
d2873c49
export
default
{
export
default
{
computed
:
{
computed
:
{
shouldRenderDraftRow
:
()
=>
()
=>
false
,
shouldRenderDraftRow
:
()
=>
()
=>
false
,
shouldRenderParallelDraftRow
:
()
=>
()
=>
false
,
draftForLine
:
()
=>
()
=>
({}),
draftForLine
:
()
=>
()
=>
({}),
},
},
};
};
ee/app/assets/javascripts/diffs/mixins/draft_comments.js
View file @
d2873c49
...
@@ -2,6 +2,10 @@ import { mapGetters } from 'vuex';
...
@@ -2,6 +2,10 @@ import { mapGetters } from 'vuex';
export
default
{
export
default
{
computed
:
{
computed
:
{
...
mapGetters
(
'
batchComments
'
,
[
'
shouldRenderDraftRow
'
,
'
draftForLine
'
]),
...
mapGetters
(
'
batchComments
'
,
[
'
shouldRenderDraftRow
'
,
'
shouldRenderParallelDraftRow
'
,
'
draftForLine
'
,
]),
},
},
};
};
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment