Feedback from review

ee/app/services/ci/external_pull_requests/process_github_event_service.rb

+# frozen_string_literal: true
+
+module Ci
+  module ExternalPullRequests
+    class ProcessGithubEventService < ::BaseService
+      # All possible statuses available here:
+      # https://developer.github.com/v3/activity/events/types/#pullrequestevent
+      GITHUB_ACTIONS_TO_STATUS = {
+        'opened'      => :open,
+        'reopened'    => :open,
+        'synchronize' => :open,
+        'closed'      => :closed
+      }.freeze
+
+      def execute(webhook_params)
+        return unless project.github_external_pull_request_pipelines_available?
+
+        params = params_from_webhook(webhook_params)
+        return unless params[:status]
+
+        # Save pull request info for later. when mirror update will run
+        # and the pipeline is created for all newly pushed branches.
+        # At that point we will be able to reference it back if a pull request
+        # was created.
+        ::ExternalPullRequest.create_or_update_from_params(params).tap do |pull_request|
+          if pull_request.errors.empty?
+            Ci::ExternalPullRequests::CreatePipelineService.new(project, current_user)
+              .execute(pull_request)
+          end
+        end
+      end
+
+      private
+
+      def params_from_webhook(params)
+        {
+          project_id: project.id,
+          pull_request_iid: params.dig(:pull_request, :number),
+          source_branch: params.dig(:pull_request, :head, :ref),
+          source_sha: params.dig(:pull_request, :head, :sha),
+          source_repository: params.dig(:pull_request, :head, :repo, :full_name),
+          target_branch: params.dig(:pull_request, :base, :ref),
+          target_sha: params.dig(:pull_request, :base, :sha),
+          target_repository: params.dig(:pull_request, :base, :repo, :full_name),
+          status: GITHUB_ACTIONS_TO_STATUS[params[:action]]
+        }
+      end
+    end
+  end
+end

ee/app/services/ci/process_github_pull_request_event_service.rb

-# frozen_string_literal: true
-
-module Ci
-  class ProcessGithubPullRequestEventService < ::BaseService
-    # All possible statuses available here:
-    # https://developer.github.com/v3/activity/events/types/#pullrequestevent
-    GITHUB_ACTIONS_TO_STATUS = {
-      'opened'      => :open,
-      'reopened'    => :open,
-      'synchronize' => :open,
-      'closed'      => :closed
-    }.freeze
-
-    def execute(webhook_params)
-      return unless project.github_external_pull_request_pipelines_available?
-
-      params = params_from_webhook(webhook_params)
-      return unless params[:status]
-
-      # Save pull request info for later. when mirror update will run
-      # and the pipeline is created for all newly pushed branches.
-      # At that point we will be able to reference it back if a pull request
-      # was created.
-      ::ExternalPullRequest.create_or_update_from_params(params).tap do |pull_request|
-        if pull_request.errors.empty?
-          Ci::ExternalPullRequests::CreatePipelineService.new(project, current_user)
-            .execute(pull_request)
-        end
-      end
-    end
-
-    private
-
-    def params_from_webhook(params)
-      {
-        project_id: project.id,
-        pull_request_iid: params.dig(:pull_request, :number),
-        source_branch: params.dig(:pull_request, :head, :ref),
-        source_sha: params.dig(:pull_request, :head, :sha),
-        source_repository: params.dig(:pull_request, :head, :repo, :full_name),
-        target_branch: params.dig(:pull_request, :base, :ref),
-        target_sha: params.dig(:pull_request, :base, :sha),
-        target_repository: params.dig(:pull_request, :base, :repo, :full_name),
-        status: GITHUB_ACTIONS_TO_STATUS[params[:action]]
-      }
-    end
-  end
-end

ee/lib/api/project_mirror.rb

@@ -49,7 +49,7 @@ module API
       end
 
       def process_pull_request
-        external_pull_request = Ci::ProcessGithubPullRequestEventService.new(project, mirror_user).execute(params)
+        external_pull_request = Ci::ExternalPullRequests::ProcessGithubEventService.new(project, mirror_user).execute(params)
 
         if external_pull_request
           render_validation_error!(external_pull_request)

ee/spec/services/ci/process_github_pull_request_event_service_spec.rb → ee/spec/services/ci/external_pull_requests/process_github_event_service_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Ci::ProcessGithubPullRequestEventService do
+describe Ci::ExternalPullRequests::ProcessGithubEventService do
   let_it_be(:project) { create(:project, :repository) }
   let_it_be(:user) { create(:user) }
   let(:action) { 'opened' }