Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
d3bf38a3
Commit
d3bf38a3
authored
Dec 17, 2020
by
Martin Wortschack
Committed by
Simon Knox
Dec 17, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove Font Awesome from FE guidelines
parent
cc60b39d
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
13 deletions
+1
-13
doc/development/fe_guide/dependencies.md
doc/development/fe_guide/dependencies.md
+1
-6
doc/development/fe_guide/icons.md
doc/development/fe_guide/icons.md
+0
-7
No files found.
doc/development/fe_guide/dependencies.md
View file @
d3bf38a3
...
...
@@ -8,12 +8,7 @@ info: To determine the technical writer assigned to the Stage/Group associated w
## Package manager
We use
[
Yarn
](
https://yarnpkg.com/
)
to manage frontend dependencies. There are a few exceptions:
-
[
FontAwesome
](
https://fontawesome.com/
)
, installed via the
`font-awesome-rails`
gem: we are working to replace it with
[
GitLab SVGs
](
https://gitlab-org.gitlab.io/gitlab-svgs/
)
icons library.
-
[
ACE
](
https://ace.c9.io/
)
editor, installed via the
`ace-rails-ap`
gem.
-
Other dependencies found under
`vendor/assets/`
.
We use
[
Yarn
](
https://yarnpkg.com/
)
to manage frontend dependencies. There are a few exceptions, stored in
`vendor/assets/`
.
## Updating dependencies
...
...
doc/development/fe_guide/icons.md
View file @
d3bf38a3
...
...
@@ -18,8 +18,6 @@ We are using SVG Icons in GitLab with a SVG Sprite.
This means the icons are only loaded once, and are referenced through an ID.
The sprite SVG is located under
`/assets/icons.svg`
.
Our goal is to replace one by one all inline SVG Icons (as those currently bloat the HTML) and also all Font Awesome icons.
### Usage in HAML/Rails
To use a sprite Icon in HAML or Rails we use a specific helper function:
...
...
@@ -90,11 +88,6 @@ Please use the following function inside JS to render an icon:
### Usage in HAML/Rails
WARNING:
Do not use the
`spinner`
or
`icon('spinner spin')`
rails helpers to insert
loading icons. These helpers rely on the Font Awesome icon library which is
deprecated.
To insert a loading spinner in HAML or Rails use the
`loading_icon`
helper:
```
haml
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment