Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
d45527c6
Commit
d45527c6
authored
Dec 13, 2021
by
Anastasia McDonald
Committed by
Ramya Authappan
Dec 13, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add extra checks to web_terminal_spec
parent
0ab4fb10
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
12 additions
and
0 deletions
+12
-0
qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb
...features/browser_ui/3_create/web_ide/web_terminal_spec.rb
+12
-0
No files found.
qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb
View file @
d45527c6
...
...
@@ -65,6 +65,7 @@ module QA
# a) The terminal JS package has loaded, and
# b) It's not stuck in a "Loading/Starting" state, and
# c) There's no alert stating there was a problem
# d) There are no JS console errors
#
# The terminal itself is a third-party package so we assume it is
# adequately tested elsewhere.
...
...
@@ -78,6 +79,17 @@ module QA
expect
(
edit
).
to
have_finished_loading
expect
(
edit
).
to
have_terminal_screen
end
# It takes a few seconds for console errors to appear
sleep
3
errors
=
page
.
driver
.
browser
.
logs
.
get
(
:browser
)
.
select
{
|
e
|
e
.
level
==
"SEVERE"
}
.
to_a
if
errors
.
present?
raise
(
"Console error(s):
\n
#{
errors
.
join
(
"
\n\n
"
)
}
"
)
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment