Commit d51a17c1 authored by Shinya Maeda's avatar Shinya Maeda

Fix review app links are not shown in MR widgets

This commit fixes the bug by correcting project-level permission.
parent ab4f3d2d
...@@ -507,6 +507,8 @@ class ProjectPolicy < BasePolicy ...@@ -507,6 +507,8 @@ class ProjectPolicy < BasePolicy
enable :read_note enable :read_note
enable :read_pipeline enable :read_pipeline
enable :read_pipeline_schedule enable :read_pipeline_schedule
enable :read_environment
enable :read_deployment
enable :read_commit_status enable :read_commit_status
enable :read_container_image enable :read_container_image
enable :download_code enable :download_code
......
---
title: Fix review app links are not shown in MR widgets in public projects
merge_request: 37923
author:
type: fixed
...@@ -479,8 +479,8 @@ RSpec.describe "Internal Project Access" do ...@@ -479,8 +479,8 @@ RSpec.describe "Internal Project Access" do
it { is_expected.to be_allowed_for(:maintainer).of(project) } it { is_expected.to be_allowed_for(:maintainer).of(project) }
it { is_expected.to be_allowed_for(:developer).of(project) } it { is_expected.to be_allowed_for(:developer).of(project) }
it { is_expected.to be_allowed_for(:reporter).of(project) } it { is_expected.to be_allowed_for(:reporter).of(project) }
it { is_expected.to be_denied_for(:guest).of(project) } it { is_expected.to be_allowed_for(:guest).of(project) }
it { is_expected.to be_denied_for(:user) } it { is_expected.to be_allowed_for(:user) }
it { is_expected.to be_denied_for(:external) } it { is_expected.to be_denied_for(:external) }
it { is_expected.to be_denied_for(:visitor) } it { is_expected.to be_denied_for(:visitor) }
end end
...@@ -495,8 +495,8 @@ RSpec.describe "Internal Project Access" do ...@@ -495,8 +495,8 @@ RSpec.describe "Internal Project Access" do
it { is_expected.to be_allowed_for(:maintainer).of(project) } it { is_expected.to be_allowed_for(:maintainer).of(project) }
it { is_expected.to be_allowed_for(:developer).of(project) } it { is_expected.to be_allowed_for(:developer).of(project) }
it { is_expected.to be_allowed_for(:reporter).of(project) } it { is_expected.to be_allowed_for(:reporter).of(project) }
it { is_expected.to be_denied_for(:guest).of(project) } it { is_expected.to be_allowed_for(:guest).of(project) }
it { is_expected.to be_denied_for(:user) } it { is_expected.to be_allowed_for(:user) }
it { is_expected.to be_denied_for(:external) } it { is_expected.to be_denied_for(:external) }
it { is_expected.to be_denied_for(:visitor) } it { is_expected.to be_denied_for(:visitor) }
end end
...@@ -511,8 +511,8 @@ RSpec.describe "Internal Project Access" do ...@@ -511,8 +511,8 @@ RSpec.describe "Internal Project Access" do
it { is_expected.to be_allowed_for(:maintainer).of(project) } it { is_expected.to be_allowed_for(:maintainer).of(project) }
it { is_expected.to be_allowed_for(:developer).of(project) } it { is_expected.to be_allowed_for(:developer).of(project) }
it { is_expected.to be_allowed_for(:reporter).of(project) } it { is_expected.to be_allowed_for(:reporter).of(project) }
it { is_expected.to be_denied_for(:guest).of(project) } it { is_expected.to be_allowed_for(:guest).of(project) }
it { is_expected.to be_denied_for(:user) } it { is_expected.to be_allowed_for(:user) }
it { is_expected.to be_denied_for(:external) } it { is_expected.to be_denied_for(:external) }
it { is_expected.to be_denied_for(:visitor) } it { is_expected.to be_denied_for(:visitor) }
end end
......
...@@ -293,10 +293,10 @@ RSpec.describe "Public Project Access" do ...@@ -293,10 +293,10 @@ RSpec.describe "Public Project Access" do
it { is_expected.to be_allowed_for(:maintainer).of(project) } it { is_expected.to be_allowed_for(:maintainer).of(project) }
it { is_expected.to be_allowed_for(:developer).of(project) } it { is_expected.to be_allowed_for(:developer).of(project) }
it { is_expected.to be_allowed_for(:reporter).of(project) } it { is_expected.to be_allowed_for(:reporter).of(project) }
it { is_expected.to be_denied_for(:guest).of(project) } it { is_expected.to be_allowed_for(:guest).of(project) }
it { is_expected.to be_denied_for(:user) } it { is_expected.to be_allowed_for(:user) }
it { is_expected.to be_denied_for(:external) } it { is_expected.to be_allowed_for(:external) }
it { is_expected.to be_denied_for(:visitor) } it { is_expected.to be_allowed_for(:visitor) }
end end
describe "GET /:project_path/-/environments/:id" do describe "GET /:project_path/-/environments/:id" do
...@@ -309,10 +309,10 @@ RSpec.describe "Public Project Access" do ...@@ -309,10 +309,10 @@ RSpec.describe "Public Project Access" do
it { is_expected.to be_allowed_for(:maintainer).of(project) } it { is_expected.to be_allowed_for(:maintainer).of(project) }
it { is_expected.to be_allowed_for(:developer).of(project) } it { is_expected.to be_allowed_for(:developer).of(project) }
it { is_expected.to be_allowed_for(:reporter).of(project) } it { is_expected.to be_allowed_for(:reporter).of(project) }
it { is_expected.to be_denied_for(:guest).of(project) } it { is_expected.to be_allowed_for(:guest).of(project) }
it { is_expected.to be_denied_for(:user) } it { is_expected.to be_allowed_for(:user) }
it { is_expected.to be_denied_for(:external) } it { is_expected.to be_allowed_for(:external) }
it { is_expected.to be_denied_for(:visitor) } it { is_expected.to be_allowed_for(:visitor) }
end end
describe "GET /:project_path/-/environments/:id/deployments" do describe "GET /:project_path/-/environments/:id/deployments" do
...@@ -325,10 +325,10 @@ RSpec.describe "Public Project Access" do ...@@ -325,10 +325,10 @@ RSpec.describe "Public Project Access" do
it { is_expected.to be_allowed_for(:maintainer).of(project) } it { is_expected.to be_allowed_for(:maintainer).of(project) }
it { is_expected.to be_allowed_for(:developer).of(project) } it { is_expected.to be_allowed_for(:developer).of(project) }
it { is_expected.to be_allowed_for(:reporter).of(project) } it { is_expected.to be_allowed_for(:reporter).of(project) }
it { is_expected.to be_denied_for(:guest).of(project) } it { is_expected.to be_allowed_for(:guest).of(project) }
it { is_expected.to be_denied_for(:user) } it { is_expected.to be_allowed_for(:user) }
it { is_expected.to be_denied_for(:external) } it { is_expected.to be_allowed_for(:external) }
it { is_expected.to be_denied_for(:visitor) } it { is_expected.to be_allowed_for(:visitor) }
end end
describe "GET /:project_path/-/environments/new" do describe "GET /:project_path/-/environments/new" do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment