Merge branch 'insights-only-display-titled-config-items' into 'master'

Insights: Only display page config with valid values

See merge request gitlab-org/gitlab-ee!14277

ee/app/assets/javascripts/insights/stores/modules/insights/mutations.js

+import _ from 'underscore';
 import * as types from './mutation_types';
 
 export default {
@@ -6,7 +7,12 @@ export default {
     state.configLoading = true;
   },
   [types.RECEIVE_CONFIG_SUCCESS](state, data) {
-    state.configData = data;
+    const validConfig = _.pick(
+      data,
+      Object.keys(data).filter(key => data[key].title && data[key].charts),
+    );
+
+    state.configData = validConfig;
     state.configLoading = false;
   },
   [types.RECEIVE_CONFIG_ERROR](state) {

ee/changelogs/unreleased/insights-only-display-titled-config-items.yml

+---
+title: 'Insights: Only display page config with valid values'
+merge_request:
+author:
+type: fixed

ee/spec/frontend/insights/stores/insights/mutations_spec.js

 import createState from 'ee/insights/stores/modules/insights/state';
 import mutations from 'ee/insights/stores/modules/insights/mutations';
 import * as types from 'ee/insights/stores/modules/insights/mutation_types';
+import { configData } from '../../../../javascripts/insights/mock_data';
 
 describe('Insights mutations', () => {
   let state;
@@ -33,22 +34,19 @@ describe('Insights mutations', () => {
   });
 
   describe(types.RECEIVE_CONFIG_SUCCESS, () => {
-    const data = [
-      {
-        key: 'chart',
-      },
-    ];
-
     it('sets configLoading state to false on success', () => {
-      mutations[types.RECEIVE_CONFIG_SUCCESS](state, data);
+      mutations[types.RECEIVE_CONFIG_SUCCESS](state, configData);
 
       expect(state.configLoading).toBe(false);
     });
 
     it('sets configData state to incoming data on success', () => {
-      mutations[types.RECEIVE_CONFIG_SUCCESS](state, data);
+      mutations[types.RECEIVE_CONFIG_SUCCESS](state, configData);
+
+      const expected = Object.assign({}, configData);
+      delete expected.invalid;
 
-      expect(state.configData).toBe(data);
+      expect(state.configData).toEqual(expected);
     });
   });
 

ee/spec/javascripts/insights/mock_data.js

@@ -36,3 +36,10 @@ export const pageInfoNoCharts = {
     title: 'Page No Charts',
   },
 };
+
+export const configData = {
+  example: pageInfo,
+  invalid: {
+    key: 'key',
+  },
+};