Merge branch 'suppress-every-non-nullable-graphql-error-assignee-widget' into 'master'

Suppress all non-nullable field errors for assignee widget graphql queries

See merge request gitlab-org/gitlab!61091

app/assets/javascripts/vue_shared/components/user_select/user_select.vue

@@ -108,10 +108,12 @@ export default {
       error({ graphQLErrors }) {
         // TODO This error suppression is temporary (BE fix required)
         // https://gitlab.com/gitlab-org/gitlab/-/issues/329750
-        if (
-          graphQLErrors.length === 1 &&
-          graphQLErrors[0]?.message === 'Cannot return null for non-nullable field GroupMember.user'
-        ) {
+        const isNullError = ({ message }) => {
+          return message === 'Cannot return null for non-nullable field GroupMember.user';
+        };
+
+        if (graphQLErrors?.length > 0 && graphQLErrors.every(isNullError)) {
+          // only null-related errors exist, suppress them.
           // eslint-disable-next-line no-console
           console.error(
             "Suppressing the error 'Cannot return null for non-nullable field GroupMember.user'. Please see https://gitlab.com/gitlab-org/gitlab/-/issues/329750",

changelogs/unreleased/suppress-every-non-nullable-graphql-error-assignee-widget.yml

+---
+title: Suppress all non-nullable field errors for assignee widget graphql queries
+  to remove assignee fetching error messages in boards
+merge_request: 61091
+author:
+type: fixed

spec/frontend/vue_shared/components/user_select_spec.js

@@ -95,14 +95,14 @@ describe('User select dropdown', () => {
     createComponent({ participantsQueryHandler: mockError });
     await waitForPromises();
 
-    expect(wrapper.emitted('error')).toBeTruthy();
+    expect(wrapper.emitted('error')).toEqual([[], []]);
   });
 
   it('emits an `error` event if search query was rejected', async () => {
     createComponent({ searchQueryHandler: mockError });
     await waitForSearch();
 
-    expect(wrapper.emitted('error')).toBeTruthy();
+    expect(wrapper.emitted('error')).toEqual([[], []]);
   });
 
   it('renders current user if they are not in participants or assignees', async () => {
@@ -264,4 +264,48 @@ describe('User select dropdown', () => {
       expect(findEmptySearchResults().exists()).toBe(true);
     });
   });
+
+  // TODO Remove this test after the following issue is resolved in the backend
+  // https://gitlab.com/gitlab-org/gitlab/-/issues/329750
+  describe('temporary error suppression', () => {
+    beforeEach(() => {
+      jest.spyOn(console, 'error').mockImplementation();
+    });
+
+    const nullError = { message: 'Cannot return null for non-nullable field GroupMember.user' };
+
+    it.each`
+      mockErrors
+      ${[nullError]}
+      ${[nullError, nullError]}
+    `('does not emit errors', async ({ mockErrors }) => {
+      createComponent({
+        searchQueryHandler: jest.fn().mockResolvedValue({
+          errors: mockErrors,
+        }),
+      });
+      await waitForSearch();
+
+      expect(wrapper.emitted()).toEqual({});
+      // eslint-disable-next-line no-console
+      expect(console.error).toHaveBeenCalled();
+    });
+
+    it.each`
+      mockErrors
+      ${[{ message: 'serious error' }]}
+      ${[nullError, { message: 'serious error' }]}
+    `('emits error when non-null related errors are included', async ({ mockErrors }) => {
+      createComponent({
+        searchQueryHandler: jest.fn().mockResolvedValue({
+          errors: mockErrors,
+        }),
+      });
+      await waitForSearch();
+
+      expect(wrapper.emitted('error')).toEqual([[]]);
+      // eslint-disable-next-line no-console
+      expect(console.error).not.toHaveBeenCalled();
+    });
+  });
 });