Merge branch 'fix/project_show_also_ldap_users' into 'master'

Fix/project show also ldap users

In 336b7b87 a feature was (silently) added which broke our use case of using LDAP synced groups as a common base for user <-> project mapping 😒

Although
>v 7.4.0
>  - [...]
>  - Do not show ldap users in dropdowns for groups with enabled ldap-sync
>  - [...]

indicates that the drop down boxes for groups have changed, it does not for projects in such a group. To be clear: It totally makes sense to not manually manage users for LDAP synced groups, on a project basis however it is very useful and an essential feature to allow self-service in organizations.

Please consider making the `skip_ldap` flag optional for the dropdown boxes.
[Also, make sure that the provider you're excluding actually is called `ldap`, which might not be the case for installations with multiple LDAP backends.](https://gitlab.com/subscribers/gitlab-ee/blob/master/lib/api/users.rb#L16)

This MR is a quick fix to disable this feature for projects.

See merge request !25

app/views/projects/team_members/_form.html.haml

@@ -12,7 +12,7 @@
   .form-group
     = f.label :user_ids, "People", class: 'control-label'
     .col-sm-10
-      = users_select_tag(:user_ids, { multiple: true, skip_ldap: @project.group_ldap_synced? })
+      = users_select_tag(:user_ids, { multiple: true })
 
   %p 2. Set access level for them
   .form-group