Merge branch '327662-feature-flag-rollout-of-ci_pipeline_ensure_iid_on_save' into 'master'

Resolve "[Feature flag] Rollout of `ci_pipeline_ensure_iid_on_save`" [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!61311

app/services/ci/create_web_ide_terminal_service.rb

@@ -29,11 +29,9 @@ module Ci
       build_pipeline.tap do |pipeline|
         pipeline.stages << terminal_stage_seed(pipeline).to_resource
 
-        if Feature.enabled?(:ci_pipeline_ensure_iid_on_save, pipeline.project, default_enabled: :yaml)
-          # Project iid must be called outside a transaction, so we ensure it is set here
-          # otherwise it may be set within the save! which it will lock the InternalId row for the whole transaction
-          pipeline.ensure_project_iid!
-        end
+        # Project iid must be called outside a transaction, so we ensure it is set here
+        # otherwise it may be set within the save! which it will lock the InternalId row for the whole transaction
+        pipeline.ensure_project_iid!
 
         pipeline.save!
 

changelogs/unreleased/327662-feature-flag-rollout-of-ci_pipeline_ensure_iid_on_save.yml

+---
+title: Ensure project iid is set before saving pipeline from web terminal
+merge_request: 61311
+author:
+type: performance

config/feature_flags/development/ci_pipeline_ensure_iid_on_save.yml

----
-name: ci_pipeline_ensure_iid_on_save
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/59341
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/327662
-milestone: '13.12'
-type: development
-group: group::code review
-default_enabled: false

spec/services/ci/create_web_ide_terminal_service_spec.rb

@@ -28,16 +28,6 @@ RSpec.describe Ci::CreateWebIdeTerminalService do
           end
           subject
         end
-
-        context 'when the ci_pipeline_ensure_iid_on_save feature flag is off' do
-          it 'does not call ensure_project_iid explicitly' do
-            stub_feature_flags(ci_pipeline_ensure_iid_on_save: false)
-            expect_next_instance_of(Ci::Pipeline) do |instance|
-              expect(instance).to receive(:ensure_project_iid!).once
-            end
-            subject
-          end
-        end
       end
 
       before do