Fix visibility icon on project overview page

- Change `vertical-align: text-bottom` to `-3px` which
works better with text that has larger font size
- Fix `visibility_level_icon` to properly accept the `class`
property
- Fix visibility icon on project overview page

app/assets/stylesheets/framework/images.scss

@@ -54,6 +54,6 @@ svg {
   }
 
   &.s16 {
-    vertical-align: text-bottom;
+    vertical-align: -3px;
   }
 }

app/assets/stylesheets/pages/projects.scss

@@ -159,7 +159,7 @@
     font-weight: bold;
 
     .icon {
-      font-size: $gl-font-size-large;
+      vertical-align: -1px;
     }
 
     .home-panel-topic-list {

app/helpers/icons_helper.rb

@@ -117,7 +117,9 @@ module IconsHelper
         'earth'
       end
 
-    sprite_icon(name, size: DEFAULT_ICON_SIZE, css_class: 'gl-vertical-align-text-bottom')
+    css_class = options.delete(:class)
+
+    sprite_icon(name, size: DEFAULT_ICON_SIZE, css_class: css_class)
   end
 
   def file_type_icon_class(type, mode, name)

app/views/projects/_home_panel.html.haml

@@ -13,7 +13,7 @@
           %h1.home-panel-title.gl-mt-3.gl-mb-2{ data: { qa_selector: 'project_name_content' } }
             = @project.name
             %span.visibility-icon.text-secondary.gl-ml-2.has-tooltip{ data: { container: 'body' }, title: visibility_icon_description(@project) }
-              = visibility_level_icon(@project.visibility_level, options: {class: 'icon'})
+              = visibility_level_icon(@project.visibility_level, options: { class: 'icon' })
             = render_if_exists 'compliance_management/compliance_framework/compliance_framework_badge', project: @project
         .home-panel-metadata.d-flex.flex-wrap.text-secondary
           - if can?(current_user, :read_project, @project)