Merge branch '276619-remove-feature-flag' into 'master'

Remove feature flag release_mr_issue_urls [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!63609

app/presenters/release_presenter.rb

@@ -26,32 +26,22 @@ class ReleasePresenter < Gitlab::View::Presenter::Delegated
   end
 
   def opened_merge_requests_url
-    return unless release_mr_issue_urls_available?
-
     project_merge_requests_url(project, params_for_issues_and_mrs)
   end
 
   def merged_merge_requests_url
-    return unless release_mr_issue_urls_available?
-
     project_merge_requests_url(project, params_for_issues_and_mrs(state: 'merged'))
   end
 
   def closed_merge_requests_url
-    return unless release_mr_issue_urls_available?
-
     project_merge_requests_url(project, params_for_issues_and_mrs(state: 'closed'))
   end
 
   def opened_issues_url
-    return unless release_mr_issue_urls_available?
-
     project_issues_url(project, params_for_issues_and_mrs)
   end
 
   def closed_issues_url
-    return unless release_mr_issue_urls_available?
-
     project_issues_url(project, params_for_issues_and_mrs(state: 'closed'))
   end
 
@@ -89,10 +79,6 @@ class ReleasePresenter < Gitlab::View::Presenter::Delegated
     { scope: 'all', state: state, release_tag: release.tag }
   end
 
-  def release_mr_issue_urls_available?
-    ::Feature.enabled?(:release_mr_issue_urls, project, default_enabled: true)
-  end
-
   def release_edit_page_available?
     can?(current_user, :update_release, release)
   end

config/feature_flags/development/release_mr_issue_urls.yml

----
-name: release_mr_issue_urls
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/18727
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/276619
-milestone: '12.4'
-type: development
-group: group::release
-default_enabled: true

spec/presenters/release_presenter_spec.rb

@@ -77,14 +77,6 @@ RSpec.describe ReleasePresenter do
     it 'returns merge requests url with state=open' do
       is_expected.to eq(project_merge_requests_url(project, opened_url_params))
     end
-
-    context 'when release_mr_issue_urls feature flag is disabled' do
-      before do
-        stub_feature_flags(release_mr_issue_urls: false)
-      end
-
-      it { is_expected.to be_nil }
-    end
   end
 
   describe '#merged_merge_requests_url' do
@@ -93,14 +85,6 @@ RSpec.describe ReleasePresenter do
     it 'returns merge requests url with state=merged' do
       is_expected.to eq(project_merge_requests_url(project, merged_url_params))
     end
-
-    context 'when release_mr_issue_urls feature flag is disabled' do
-      before do
-        stub_feature_flags(release_mr_issue_urls: false)
-      end
-
-      it { is_expected.to be_nil }
-    end
   end
 
   describe '#closed_merge_requests_url' do
@@ -109,14 +93,6 @@ RSpec.describe ReleasePresenter do
     it 'returns merge requests url with state=closed' do
       is_expected.to eq(project_merge_requests_url(project, closed_url_params))
     end
-
-    context 'when release_mr_issue_urls feature flag is disabled' do
-      before do
-        stub_feature_flags(release_mr_issue_urls: false)
-      end
-
-      it { is_expected.to be_nil }
-    end
   end
 
   describe '#opened_issues_url' do
@@ -125,14 +101,6 @@ RSpec.describe ReleasePresenter do
     it 'returns issues url with state=open' do
       is_expected.to eq(project_issues_url(project, opened_url_params))
     end
-
-    context 'when release_mr_issue_urls feature flag is disabled' do
-      before do
-        stub_feature_flags(release_mr_issue_urls: false)
-      end
-
-      it { is_expected.to be_nil }
-    end
   end
 
   describe '#closed_issues_url' do
@@ -141,14 +109,6 @@ RSpec.describe ReleasePresenter do
     it 'returns issues url with state=closed' do
       is_expected.to eq(project_issues_url(project, closed_url_params))
     end
-
-    context 'when release_mr_issue_urls feature flag is disabled' do
-      before do
-        stub_feature_flags(release_mr_issue_urls: false)
-      end
-
-      it { is_expected.to be_nil }
-    end
   end
 
   describe '#edit_url' do