Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
da431c43
Commit
da431c43
authored
Jun 03, 2019
by
Avielle Wolfe
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove "Module" from vulnerability feedback module name
This is not a pattern we use.
parent
07a83845
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
7 additions
and
7 deletions
+7
-7
ee/app/controllers/projects/vulnerability_feedback_controller.rb
...controllers/projects/vulnerability_feedback_controller.rb
+2
-2
ee/app/services/vulnerability_feedback/create_service.rb
ee/app/services/vulnerability_feedback/create_service.rb
+1
-1
ee/app/services/vulnerability_feedback/destroy_service.rb
ee/app/services/vulnerability_feedback/destroy_service.rb
+1
-1
ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb
...ollers/projects/vulnerability_feedback_controller_spec.rb
+1
-1
ee/spec/services/ee/vulnerability_feedback/create_service_spec.rb
...services/ee/vulnerability_feedback/create_service_spec.rb
+1
-1
ee/spec/services/ee/vulnerability_feedback/destroy_service_spec.rb
...ervices/ee/vulnerability_feedback/destroy_service_spec.rb
+1
-1
No files found.
ee/app/controllers/projects/vulnerability_feedback_controller.rb
View file @
da431c43
...
...
@@ -29,7 +29,7 @@ class Projects::VulnerabilityFeedbackController < Projects::ApplicationControlle
# rubocop: enable CodeReuse/ActiveRecord
def
create
service
=
VulnerabilityFeedback
Module
::
CreateService
.
new
(
project
,
current_user
,
vulnerability_feedback_params
)
service
=
VulnerabilityFeedback
::
CreateService
.
new
(
project
,
current_user
,
vulnerability_feedback_params
)
result
=
service
.
execute
if
result
[
:status
]
==
:success
...
...
@@ -40,7 +40,7 @@ class Projects::VulnerabilityFeedbackController < Projects::ApplicationControlle
end
def
destroy
service
=
VulnerabilityFeedback
Module
::
DestroyService
.
new
(
project
,
current_user
,
vulnerability_feedback
)
service
=
VulnerabilityFeedback
::
DestroyService
.
new
(
project
,
current_user
,
vulnerability_feedback
)
service
.
execute
head
:no_content
...
...
ee/app/services/vulnerability_feedback
_module
/create_service.rb
→
ee/app/services/vulnerability_feedback/create_service.rb
View file @
da431c43
# frozen_string_literal: true
module
VulnerabilityFeedback
Module
module
VulnerabilityFeedback
class
CreateService
<
::
BaseService
def
execute
vulnerability_feedback
=
@project
.
vulnerability_feedback
.
find_or_init_for
(
create_params
)
...
...
ee/app/services/vulnerability_feedback
_module
/destroy_service.rb
→
ee/app/services/vulnerability_feedback/destroy_service.rb
View file @
da431c43
# frozen_string_literal: true
module
VulnerabilityFeedback
Module
module
VulnerabilityFeedback
class
DestroyService
<
::
BaseService
def
initialize
(
project
,
user
,
vulnerability_feedback
)
@project
,
@current_user
,
@vulnerability_feedback
=
project
,
user
,
vulnerability_feedback
...
...
ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb
View file @
da431c43
...
...
@@ -115,7 +115,7 @@ describe Projects::VulnerabilityFeedbackController do
context
'with valid params'
do
it
'returns the created feedback'
do
allow
(
VulnerabilityFeedback
Module
::
CreateService
)
allow
(
VulnerabilityFeedback
::
CreateService
)
.
to
receive
(
:new
).
with
(
project
,
user
,
ActionController
::
Parameters
.
new
(
create_params
).
permit!
)
.
and_call_original
...
...
ee/spec/services/ee/vulnerability_feedback
_module
/create_service_spec.rb
→
ee/spec/services/ee/vulnerability_feedback/create_service_spec.rb
View file @
da431c43
require
'spec_helper'
describe
VulnerabilityFeedback
Module
::
CreateService
,
'#execute'
do
describe
VulnerabilityFeedback
::
CreateService
,
'#execute'
do
let
(
:group
)
{
create
(
:group
)
}
let
(
:project
)
{
create
(
:project
,
:public
,
:repository
,
namespace:
group
)
}
let
(
:user
)
{
create
(
:user
)
}
...
...
ee/spec/services/ee/vulnerability_feedback
_module
/destroy_service_spec.rb
→
ee/spec/services/ee/vulnerability_feedback/destroy_service_spec.rb
View file @
da431c43
...
...
@@ -2,7 +2,7 @@
require
'spec_helper'
describe
VulnerabilityFeedback
Module
::
DestroyService
,
'#execute'
do
describe
VulnerabilityFeedback
::
DestroyService
,
'#execute'
do
let
(
:group
)
{
create
(
:group
)
}
let
(
:project
)
{
create
(
:project
,
:public
,
:repository
,
namespace:
group
)
}
let
(
:user
)
{
create
(
:user
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment