Merge branch 'winh-join-issuables-helper-specs' into 'master'

Join IssuablesHelper specs

See merge request gitlab-org/gitlab!17938

ee/spec/helpers/ee/issuables_helper_spec.rb

@@ -3,42 +3,53 @@
 require 'spec_helper'
 
 describe IssuablesHelper do
+  let_it_be(:user) { create(:user) }
+
   describe '#issuable_initial_data' do
     before do
+      allow(helper).to receive(:current_user).and_return(user)
+      allow(helper).to receive(:can?).and_return(true)
       stub_commonmark_sourcepos_disabled
     end
 
-    it 'returns the correct data for an epic' do
-      user = create(:user)
-      epic = create(:epic, author: user, description: 'epic text')
-      @group = epic.group
+    context 'for an epic' do
+      it 'returns the correct data' do
+        epic = create(:epic, author: user, description: 'epic text')
+        @group = epic.group
 
-      allow(helper).to receive(:current_user).and_return(user)
-      allow(helper).to receive(:can?).and_return(true)
+        expected_data = {
+          endpoint: "/groups/#{@group.full_path}/-/epics/#{epic.iid}",
+          epicLinksEndpoint: "/groups/#{@group.full_path}/-/epics/#{epic.iid}/links",
+          updateEndpoint: "/groups/#{@group.full_path}/-/epics/#{epic.iid}.json",
+          issueLinksEndpoint: "/groups/#{@group.full_path}/-/epics/#{epic.iid}/issues",
+          canUpdate: true,
+          canDestroy: true,
+          canAdmin: true,
+          issuableRef: "&#{epic.iid}",
+          markdownPreviewPath: "/groups/#{@group.full_path}/preview_markdown",
+          markdownDocsPath: '/help/user/markdown',
+          issuableTemplateNamesPath: '',
+          lockVersion: epic.lock_version,
+          fullPath: @group.full_path,
+          groupPath: @group.path,
+          initialTitleHtml: epic.title,
+          initialTitleText: epic.title,
+          initialDescriptionHtml: '<p dir="auto">epic text</p>',
+          initialDescriptionText: 'epic text',
+          initialTaskStatus: '0 of 0 tasks completed',
+          projectsEndpoint: "/api/v4/groups/#{@group.id}/projects"
+        }
+        expect(helper.issuable_initial_data(epic)).to eq(expected_data)
+      end
+    end
+
+    context 'for an issue' do
+      it 'returns the correct data that includes canAdmin: true' do
+        issue = create(:issue, author: user, description: 'issue text')
+        @project = issue.project
 
-      expected_data = {
-        endpoint: "/groups/#{@group.full_path}/-/epics/#{epic.iid}",
-        epicLinksEndpoint: "/groups/#{@group.full_path}/-/epics/#{epic.iid}/links",
-        updateEndpoint: "/groups/#{@group.full_path}/-/epics/#{epic.iid}.json",
-        issueLinksEndpoint: "/groups/#{@group.full_path}/-/epics/#{epic.iid}/issues",
-        canUpdate: true,
-        canDestroy: true,
-        canAdmin: true,
-        issuableRef: "&#{epic.iid}",
-        markdownPreviewPath: "/groups/#{@group.full_path}/preview_markdown",
-        markdownDocsPath: '/help/user/markdown',
-        issuableTemplateNamesPath: '',
-        lockVersion: epic.lock_version,
-        fullPath: @group.full_path,
-        groupPath: @group.path,
-        initialTitleHtml: epic.title,
-        initialTitleText: epic.title,
-        initialDescriptionHtml: '<p dir="auto">epic text</p>',
-        initialDescriptionText: 'epic text',
-        initialTaskStatus: '0 of 0 tasks completed',
-        projectsEndpoint: "/api/v4/groups/#{@group.id}/projects"
-      }
-      expect(helper.issuable_initial_data(epic)).to eq(expected_data)
+        expect(helper.issuable_initial_data(issue)).to include(canAdmin: true)
+      end
     end
   end
 end

ee/spec/helpers/issuables_helper_spec.rb

-# frozen_string_literal: true
-
-require 'spec_helper'
-
-describe IssuablesHelper do
-  describe '#issuable_initial_data' do
-    let(:user) { create(:user) }
-
-    before do
-      allow(helper).to receive(:current_user).and_return(user)
-      allow(helper).to receive(:can?).and_return(true)
-      stub_commonmark_sourcepos_disabled
-    end
-
-    it 'returns the correct data that includes canAdmin: true' do
-      issue = create(:issue, author: user, description: 'issue text')
-      @project = issue.project
-
-      expect(helper.issuable_initial_data(issue)).to include(canAdmin: true)
-    end
-  end
-end