Merge branch 'rails-save-bang-ee-spec-models-ci' into 'master'

Fix Rails/SaveBang offenses in ee/spec/models/ci

See merge request gitlab-org/gitlab!58109

.rubocop_manual_todo.yml

@@ -67,8 +67,6 @@ Rails/SaveBang:
     - 'ee/spec/models/approval_merge_request_rule_spec.rb'
     - 'ee/spec/models/approval_project_rule_spec.rb'
     - 'ee/spec/models/burndown_spec.rb'
-    - 'ee/spec/models/ci/pipeline_spec.rb'
-    - 'ee/spec/models/ci/subscriptions/project_spec.rb'
     - 'ee/spec/models/ee/appearance_spec.rb'
     - 'ee/spec/models/ee/ci/job_artifact_spec.rb'
     - 'ee/spec/models/ee/protected_branch_spec.rb'

ee/changelogs/unreleased/rails-save-bang-ee-spec-models-ci.yml

+---
+title: Fix Rails/SaveBang rubocop offenses in ee/spec/models/ci
+merge_request: 58109
+author: Abdul Wadood @abdulwd
+type: fixed

ee/spec/models/ci/pipeline_spec.rb

@@ -270,8 +270,8 @@ RSpec.describe Ci::Pipeline do
 
       context 'when builds are retried' do
         before do
-          build_1.update(retried: true)
-          build_2.update(retried: true)
+          build_1.update!(retried: true)
+          build_2.update!(retried: true)
         end
 
         it 'does not take retried builds into account' do
@@ -309,8 +309,8 @@ RSpec.describe Ci::Pipeline do
 
       context 'when builds are retried' do
         before do
-          build.update(retried: true)
-          build1.update(retried: true)
+          build.update!(retried: true)
+          build1.update!(retried: true)
         end
 
         it 'does not take retried builds into account' do
@@ -392,7 +392,7 @@ RSpec.describe Ci::Pipeline do
 
       context 'when pipeline runs on a tag' do
         before do
-          pipeline.update(tag: true)
+          pipeline.update!(tag: true)
         end
 
         context 'when feature is not available' do

ee/spec/models/ci/subscriptions/project_spec.rb

@@ -21,7 +21,7 @@ RSpec.describe Ci::Subscriptions::Project do
     it { is_expected.to validate_uniqueness_of(:upstream_project_id).scoped_to(:downstream_project_id) }
 
     it 'validates that upstream project is public' do
-      upstream_project.update(visibility_level: Gitlab::VisibilityLevel::PRIVATE)
+      upstream_project.update!(visibility_level: Gitlab::VisibilityLevel::PRIVATE)
 
       expect(subscription).not_to be_valid
     end