Merge branch 'jivanvl-remove-ci-trace-read-consistency-ff' into 'master'

Remove ci-trace-read-consistency feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!62840

app/models/ci/build_trace_chunk.rb

@@ -85,16 +85,10 @@ module Ci
       # change the behavior in CE.
       #
       def with_read_consistency(build, &block)
-        return yield unless consistent_reads_enabled?(build)
-
         ::Gitlab::Database::Consistency
           .with_read_consistency(&block)
       end
 
-      def consistent_reads_enabled?(build)
-        Feature.enabled?(:gitlab_ci_trace_read_consistency, build.project, type: :development, default_enabled: true)
-      end
-
       ##
       # Sometimes we do not want to read raw data. This method makes it easier
       # to find attributes that are just metadata excluding raw data.

config/feature_flags/development/gitlab_ci_trace_read_consistency.yml

----
-name: gitlab_ci_trace_read_consistency
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/46976
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/320938
-milestone: '13.9'
-type: development
-group: group::continuous integration
-default_enabled: true

lib/gitlab/ci/trace/chunked_io.rb

@@ -229,13 +229,8 @@ module Gitlab
 
         def next_chunk
           @chunks_cache[chunk_index] = begin
-            if ::Ci::BuildTraceChunk.consistent_reads_enabled?(build)
-              ::Ci::BuildTraceChunk
-                .safe_find_or_create_by(build: build, chunk_index: chunk_index)
-            else
-              ::Ci::BuildTraceChunk
-                .new(build: build, chunk_index: chunk_index)
-            end
+            ::Ci::BuildTraceChunk
+              .safe_find_or_create_by(build: build, chunk_index: chunk_index)
           end
         end
 

spec/lib/gitlab/ci/trace/chunked_io_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe Gitlab::Ci::Trace::ChunkedIO, :clean_gitlab_redis_cache do
   let(:chunked_io) { described_class.new(build) }
 
   before do
-    stub_feature_flags(ci_enable_live_trace: true, gitlab_ci_trace_read_consistency: true)
+    stub_feature_flags(ci_enable_live_trace: true)
   end
 
   describe "#initialize" do

spec/models/ci/build_trace_chunk_spec.rb

@@ -18,7 +18,7 @@ RSpec.describe Ci::BuildTraceChunk, :clean_gitlab_redis_shared_state do
   it_behaves_like 'having unique enum values'
 
   before do
-    stub_feature_flags(ci_enable_live_trace: true, gitlab_ci_trace_read_consistency: true)
+    stub_feature_flags(ci_enable_live_trace: true)
     stub_artifacts_object_storage
   end