Commit db49f207 authored by Quang-Minh Nguyen's avatar Quang-Minh Nguyen

Address the feedback of the reviewer

Issue https://gitlab.com/groups/gitlab-org/-/epics/5590
parent 704c4b1e
......@@ -56,11 +56,11 @@ export default {
metricDetailsSummary() {
const summary = {};
if (!this.metricDetails.summaryOptions || !this.metricDetails.summaryOptions.hideTotal) {
if (!this.metricDetails.summaryOptions?.hideTotal) {
summary[s__('Total')] = this.metricDetails.calls;
}
if (!this.metricDetails.summaryOptions || !this.metricDetails.summaryOptions.hideDuration) {
if (!this.metricDetails.summaryOptions?.hideDuration) {
summary[s__('PerformanceBar|Total duration')] = this.metricDetails.duration;
}
......
......@@ -84,8 +84,8 @@ const initPerformanceBar = (el) => {
summary = {
[s__('PerformanceBar|Backend')]: backend,
[s__('PerformanceBar|First contentful paint')]: firstContentfulPaint,
[s__('PerformanceBar|Dom content loaded')]: domContentLoaded,
[s__('PerformanceBar|First Contentful Paint')]: firstContentfulPaint,
[s__('PerformanceBar|DOM Content Loaded')]: domContentLoaded,
};
durationString = `${backend} | ${firstContentfulPaint} | ${domContentLoaded}`;
......
......@@ -22640,7 +22640,7 @@ msgstr ""
msgid "PerformanceBar|Bullet notifications"
msgstr ""
msgid "PerformanceBar|Dom content loaded"
msgid "PerformanceBar|DOM Content Loaded"
msgstr ""
msgid "PerformanceBar|Download"
......@@ -22652,7 +22652,7 @@ msgstr ""
msgid "PerformanceBar|External Http calls"
msgstr ""
msgid "PerformanceBar|First contentful paint"
msgid "PerformanceBar|First Contentful Paint"
msgstr ""
msgid "PerformanceBar|Frontend resources"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment