Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
db49f207
Commit
db49f207
authored
Apr 08, 2021
by
Quang-Minh Nguyen
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Address the feedback of the reviewer
Issue
https://gitlab.com/groups/gitlab-org/-/epics/5590
parent
704c4b1e
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
6 deletions
+6
-6
app/assets/javascripts/performance_bar/components/detailed_metric.vue
...avascripts/performance_bar/components/detailed_metric.vue
+2
-2
app/assets/javascripts/performance_bar/index.js
app/assets/javascripts/performance_bar/index.js
+2
-2
locale/gitlab.pot
locale/gitlab.pot
+2
-2
No files found.
app/assets/javascripts/performance_bar/components/detailed_metric.vue
View file @
db49f207
...
...
@@ -56,11 +56,11 @@ export default {
metricDetailsSummary
()
{
const
summary
=
{};
if
(
!
this
.
metricDetails
.
summaryOptions
||
!
this
.
metricDetails
.
summaryOptions
.
hideTotal
)
{
if
(
!
this
.
metricDetails
.
summaryOptions
?
.
hideTotal
)
{
summary
[
s__
(
'
Total
'
)]
=
this
.
metricDetails
.
calls
;
}
if
(
!
this
.
metricDetails
.
summaryOptions
||
!
this
.
metricDetails
.
summaryOptions
.
hideDuration
)
{
if
(
!
this
.
metricDetails
.
summaryOptions
?
.
hideDuration
)
{
summary
[
s__
(
'
PerformanceBar|Total duration
'
)]
=
this
.
metricDetails
.
duration
;
}
...
...
app/assets/javascripts/performance_bar/index.js
View file @
db49f207
...
...
@@ -84,8 +84,8 @@ const initPerformanceBar = (el) => {
summary
=
{
[
s__
(
'
PerformanceBar|Backend
'
)]:
backend
,
[
s__
(
'
PerformanceBar|First
contentful p
aint
'
)]:
firstContentfulPaint
,
[
s__
(
'
PerformanceBar|D
om content l
oaded
'
)]:
domContentLoaded
,
[
s__
(
'
PerformanceBar|First
Contentful P
aint
'
)]:
firstContentfulPaint
,
[
s__
(
'
PerformanceBar|D
OM Content L
oaded
'
)]:
domContentLoaded
,
};
durationString
=
`
${
backend
}
|
${
firstContentfulPaint
}
|
${
domContentLoaded
}
`
;
...
...
locale/gitlab.pot
View file @
db49f207
...
...
@@ -22640,7 +22640,7 @@ msgstr ""
msgid "PerformanceBar|Bullet notifications"
msgstr ""
msgid "PerformanceBar|D
om content l
oaded"
msgid "PerformanceBar|D
OM Content L
oaded"
msgstr ""
msgid "PerformanceBar|Download"
...
...
@@ -22652,7 +22652,7 @@ msgstr ""
msgid "PerformanceBar|External Http calls"
msgstr ""
msgid "PerformanceBar|First
contentful p
aint"
msgid "PerformanceBar|First
Contentful P
aint"
msgstr ""
msgid "PerformanceBar|Frontend resources"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment