Rename existing Epic#issues to Epic#issues_readable_by

The name is reserved for more common association methods.

ee/app/models/ee/epic.rb

@@ -142,7 +142,7 @@ module EE
     def update_project_counter_caches
     end
 
-    def issues(current_user)
+    def issues_readable_by(current_user)
       related_issues = ::Issue.select('issues.*, epic_issues.id as epic_issue_id, epic_issues.relative_position')
         .joins(:epic_issue)
         .where("epic_issues.epic_id = #{id}")

ee/app/services/epic_issues/list_service.rb

@@ -5,7 +5,7 @@ module EpicIssues
     def issues
       return [] unless issuable&.group&.feature_available?(:epics)
 
-      issuable.issues(current_user)
+      issuable.issues_readable_by(current_user)
     end
 
     def relation_path(issue)

ee/lib/api/epic_issues.rb

@@ -53,7 +53,7 @@ module API
         # For now we return empty body
         # The issues list in the correct order in body will be returned as part of #4250
         if result
-          present epic.issues(current_user),
+          present epic.issues_readable_by(current_user),
             with: EE::API::Entities::EpicIssue,
             current_user: current_user
         else
@@ -70,7 +70,7 @@ module API
       get ':id/(-/)epics/:epic_iid/issues' do
         authorize_can_read!
 
-        present epic.issues(current_user),
+        present epic.issues_readable_by(current_user),
           with: EE::API::Entities::EpicIssue,
           current_user: current_user
       end

ee/spec/models/epic_spec.rb

@@ -180,7 +180,7 @@ describe Epic do
     end
   end
 
-  describe '#issues' do
+  describe '#issues_readable_by' do
     let(:user) { create(:user) }
     let(:group) { create(:group, :private) }
     let(:project) { create(:project, group: group) }
@@ -197,7 +197,7 @@ describe Epic do
       ]
     end
 
-    let(:result) { epic.issues(user) }
+    let(:result) { epic.issues_readable_by(user) }
 
     it 'returns all issues if a user has access to them' do
       group.add_developer(user)