Commit dbb9d75c authored by Kamil Trzciński's avatar Kamil Trzciński

Merge branch 'fix/sm/http-io-returns-nil-path' into 'master'

Fix http_io to make it return path is nil

Closes #5119

See merge request gitlab-org/gitlab-ee!4833
parents 2ce42edf b8f7b4b2
...@@ -37,6 +37,10 @@ module Gitlab ...@@ -37,6 +37,10 @@ module Gitlab
end end
def path def path
nil
end
def url
@uri.to_s @uri.to_s
end end
......
...@@ -28,6 +28,12 @@ describe Gitlab::Ci::Trace::HttpIO do ...@@ -28,6 +28,12 @@ describe Gitlab::Ci::Trace::HttpIO do
describe '#path' do describe '#path' do
subject { http_io.path } subject { http_io.path }
it { is_expected.to be_nil }
end
describe '#url' do
subject { http_io.url }
it { is_expected.to eq(url) } it { is_expected.to eq(url) }
end end
......
...@@ -8,7 +8,7 @@ module Gitlab ...@@ -8,7 +8,7 @@ module Gitlab
attr_reader :stream attr_reader :stream
delegate :close, :tell, :seek, :size, :path, :truncate, to: :stream, allow_nil: true delegate :close, :tell, :seek, :size, :path, :url, :truncate, to: :stream, allow_nil: true
delegate :valid?, to: :stream, as: :present?, allow_nil: true delegate :valid?, to: :stream, as: :present?, allow_nil: true
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment