Commit dcef079a authored by Etienne Baqué's avatar Etienne Baqué

Merge branch '334702-resolve-rubocop-todos-on-member-creation-process' into 'master'

Resolve rubocop todos on member creation process

See merge request gitlab-org/gitlab!67537
parents c8fd3927 03dcd931
...@@ -296,7 +296,7 @@ class Group < Namespace ...@@ -296,7 +296,7 @@ class Group < Namespace
end end
def add_users(users, access_level, current_user: nil, expires_at: nil) def add_users(users, access_level, current_user: nil, expires_at: nil)
Members::Groups::CreatorService.add_users( # rubocop:todo CodeReuse/ServiceClass Members::Groups::CreatorService.add_users( # rubocop:disable CodeReuse/ServiceClass
self, self,
users, users,
access_level, access_level,
...@@ -306,7 +306,7 @@ class Group < Namespace ...@@ -306,7 +306,7 @@ class Group < Namespace
end end
def add_user(user, access_level, current_user: nil, expires_at: nil, ldap: false) def add_user(user, access_level, current_user: nil, expires_at: nil, ldap: false)
Members::Groups::CreatorService.new(self, # rubocop:todo CodeReuse/ServiceClass Members::Groups::CreatorService.new(self, # rubocop:disable CodeReuse/ServiceClass
user, user,
access_level, access_level,
current_user: current_user, current_user: current_user,
......
...@@ -44,7 +44,7 @@ class ProjectMember < Member ...@@ -44,7 +44,7 @@ class ProjectMember < Member
project_ids.each do |project_id| project_ids.each do |project_id|
project = Project.find(project_id) project = Project.find(project_id)
Members::Projects::CreatorService.add_users( # rubocop:todo CodeReuse/ServiceClass Members::Projects::CreatorService.add_users( # rubocop:disable CodeReuse/ServiceClass
project, project,
users, users,
access_level, access_level,
......
...@@ -42,7 +42,7 @@ class ProjectTeam ...@@ -42,7 +42,7 @@ class ProjectTeam
end end
def add_users(users, access_level, current_user: nil, expires_at: nil) def add_users(users, access_level, current_user: nil, expires_at: nil)
Members::Projects::CreatorService.add_users( # rubocop:todo CodeReuse/ServiceClass Members::Projects::CreatorService.add_users( # rubocop:disable CodeReuse/ServiceClass
project, project,
users, users,
access_level, access_level,
...@@ -52,7 +52,7 @@ class ProjectTeam ...@@ -52,7 +52,7 @@ class ProjectTeam
end end
def add_user(user, access_level, current_user: nil, expires_at: nil) def add_user(user, access_level, current_user: nil, expires_at: nil)
Members::Projects::CreatorService.new(project, # rubocop:todo CodeReuse/ServiceClass Members::Projects::CreatorService.new(project, # rubocop:disable CodeReuse/ServiceClass
user, user,
access_level, access_level,
current_user: current_user, current_user: current_user,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment