Commit ddc17b0f authored by Jason Goodman's avatar Jason Goodman

Sort ip ranges in groups controller specs

Avoid failures due to nondeterministic order
parent 8d8c1e2e
...@@ -32,8 +32,8 @@ RSpec.describe GroupsController, type: :request do ...@@ -32,8 +32,8 @@ RSpec.describe GroupsController, type: :request do
shared_examples 'creates ip restrictions' do shared_examples 'creates ip restrictions' do
it 'creates ip restrictions' do it 'creates ip restrictions' do
expect { subject } expect { subject }
.to(change { group.reload.ip_restrictions.map(&:range) } .to(change { group.reload.ip_restrictions.map(&:range).sort }
.from([]).to(range.split(','))) .from([]).to(range.split(',').sort))
expect(response).to have_gitlab_http_status(:found) expect(response).to have_gitlab_http_status(:found)
end end
end end
...@@ -72,8 +72,8 @@ RSpec.describe GroupsController, type: :request do ...@@ -72,8 +72,8 @@ RSpec.describe GroupsController, type: :request do
shared_examples 'updates ip restrictions' do shared_examples 'updates ip restrictions' do
it 'updates ip restrictions' do it 'updates ip restrictions' do
expect { subject } expect { subject }
.to(change { group.reload.ip_restrictions.map(&:range) } .to(change { group.reload.ip_restrictions.map(&:range).sort }
.from(['10.0.0.0/8']).to(range.split(','))) .from(['10.0.0.0/8']).to(range.split(',').sort))
expect(response).to have_gitlab_http_status(:found) expect(response).to have_gitlab_http_status(:found)
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment