Commit df3d3f4a authored by Marcin Sedlak-Jakubowski's avatar Marcin Sedlak-Jakubowski

Merge branch 'cablett-review-assets' into 'master'

Add asset access to code review guidelines

See merge request gitlab-org/gitlab!84552
parents 83c0b74e f8a0af41
...@@ -241,6 +241,8 @@ warrant a comment could be: ...@@ -241,6 +241,8 @@ warrant a comment could be:
- Any benchmarking performed to complement the change. - Any benchmarking performed to complement the change.
- Potentially insecure code. - Potentially insecure code.
If there are any projects, snippets, or other assets that are required for a reviewer to validate the solution, ensure they have access to those assets before requesting review.
Avoid: Avoid:
- Adding TODO comments (referenced above) directly to the source code unless the reviewer requires - Adding TODO comments (referenced above) directly to the source code unless the reviewer requires
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment