Commit e0d2bc89 authored by Tanya Pazitny's avatar Tanya Pazitny

Merge branch 'egb-refactor-dashboard-images-spec' into 'master'

Refactor qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb to use `let` and `before` syntax

See merge request gitlab-org/gitlab!34122
parents 30c1d8c9 66067137
......@@ -2,35 +2,41 @@
module QA
RSpec.describe 'Plan', :reliable do
let(:user) do
Resource::User.fabricate_via_api! do |user|
user.name = "eve <img src=x onerror=alert(2)&lt;img src=x onerror=alert(1)&gt;"
user.password = "test1234"
end
end
let(:project) do
Resource::Project.fabricate_via_api! do |project|
project.name = 'xss-test-for-mentions-project'
end
end
describe 'check xss occurence in @mentions in issues', :requires_admin do
it 'mentions a user in a comment' do
before do
QA::Runtime::Env.personal_access_token = QA::Runtime::Env.admin_personal_access_token
unless QA::Runtime::Env.personal_access_token
Flow::Login.sign_in_as_admin
end
user = Resource::User.fabricate_via_api! do |user|
user.name = "eve <img src=x onerror=alert(2)&lt;img src=x onerror=alert(1)&gt;"
user.password = "test1234"
end
QA::Runtime::Env.personal_access_token = nil
Page::Main::Menu.perform(&:sign_out) if Page::Main::Menu.perform { |p| p.has_personal_area?(wait: 0) }
Flow::Login.sign_in
project = Resource::Project.fabricate_via_api! do |project|
project.name = 'xss-test-for-mentions-project'
end
Flow::Project.add_member(project: project, username: user.username)
Resource::Issue.fabricate_via_api! do |issue|
issue.project = project
end.visit!
end
it 'mentions a user in a comment' do
Page::Project::Issue::Show.perform do |show|
show.select_all_activities_filter
show.comment("cc-ing you here @#{user.username}")
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment