Commit e130b170 authored by Ezekiel Kigbo's avatar Ezekiel Kigbo

Address minor review comments

parent bc01af28
......@@ -53,7 +53,7 @@ export default {
/>
</gl-form-group>
<confirm-danger
qa-button-class="qa-transfer-button"
button-class="qa-transfer-button"
:disabled="!hasSelectedNamespace"
:phrase="confirmationPhrase"
:button-text="confirmButtonText"
......
......@@ -39,7 +39,9 @@ export default () => {
},
on: {
selectNamespace: (id) => {
if (targetHiddenInputId) document.getElementById(targetHiddenInputId).value = id;
if (targetHiddenInputId && document.getElementById(targetHiddenInputId)?.value) {
document.getElementById(targetHiddenInputId).value = id;
}
},
confirm: () => {
if (targetFormId) document.getElementById(targetFormId)?.submit();
......
......@@ -36,11 +36,6 @@ export default {
required: false,
default: 'confirm-danger-button',
},
qaButtonClass: {
type: String,
required: false,
default: '',
},
},
modalId: CONFIRM_DANGER_MODAL_ID,
};
......
......@@ -69,29 +69,25 @@ export default {
<template #header>
<gl-search-box-by-type v-model.trim="searchTerm" />
</template>
<template v-if="hasGroupNamespaces">
<div class="qa-namespaces-list-groups">
<gl-dropdown-section-header>{{ $options.i18n.GROUPS }}</gl-dropdown-section-header>
<gl-dropdown-item
v-for="item in filteredGroupNamespaces"
:key="item.id"
class="qa-namespaces-list-item"
@click="handleSelect(item)"
>{{ item.humanName }}</gl-dropdown-item
>
</div>
</template>
<template v-if="hasUserNamespaces">
<div class="qa-namespaces-list-users">
<gl-dropdown-section-header>{{ $options.i18n.USERS }}</gl-dropdown-section-header>
<gl-dropdown-item
v-for="item in filteredUserNamespaces"
:key="item.id"
class="qa-namespaces-list-item"
@click="handleSelect(item)"
>{{ item.humanName }}</gl-dropdown-item
>
</div>
</template>
<div v-if="hasGroupNamespaces" class="qa-namespaces-list-groups">
<gl-dropdown-section-header>{{ $options.i18n.GROUPS }}</gl-dropdown-section-header>
<gl-dropdown-item
v-for="item in filteredGroupNamespaces"
:key="item.id"
class="qa-namespaces-list-item"
@click="handleSelect(item)"
>{{ item.humanName }}</gl-dropdown-item
>
</div>
<div v-if="hasUserNamespaces" class="qa-namespaces-list-users">
<gl-dropdown-section-header>{{ $options.i18n.USERS }}</gl-dropdown-section-header>
<gl-dropdown-item
v-for="item in filteredUserNamespaces"
:key="item.id"
class="qa-namespaces-list-item"
@click="handleSelect(item)"
>{{ item.humanName }}</gl-dropdown-item
>
</div>
</gl-dropdown>
</template>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment