Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e181d4ed
Commit
e181d4ed
authored
Dec 12, 2017
by
Michael Kozono
Committed by
Stan Hu
Dec 12, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix spec by avoiding monkeypatching
parent
031b64bf
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
13 additions
and
4 deletions
+13
-4
spec/lib/gitlab/background_migration/populate_untracked_uploads_spec.rb
...b/background_migration/populate_untracked_uploads_spec.rb
+13
-4
No files found.
spec/lib/gitlab/background_migration/populate_untracked_uploads_spec.rb
View file @
e181d4ed
...
...
@@ -182,13 +182,22 @@ describe Gitlab::BackgroundMigration::PopulateUntrackedUploads, :sidekiq do
end
context
'for a pre-Markdown Note attachment file path'
do
class
Note
<
ActiveRecord
::
Base
has_many
:uploads
,
as: :model
,
dependent: :destroy
let
(
:model
)
{
create
(
:note
,
:with_attachment
)
}
let!
(
:expected_upload_attrs
)
{
Upload
.
where
(
model_type:
'Note'
,
model_id:
model
.
id
).
first
.
attributes
.
slice
(
'path'
,
'uploader'
,
'size'
,
'checksum'
)
}
let!
(
:untracked_file
)
{
untracked_files_for_uploads
.
create!
(
path:
expected_upload_attrs
[
'path'
])
}
before
do
Upload
.
where
(
model_type:
'Note'
,
model_id:
model
.
id
).
delete_all
end
let
(
:model
)
{
create
(
:note
,
:with_attachment
)
}
# Can't use the shared example because Note doesn't have an `uploads` association
it
'creates an Upload record'
do
expect
do
subject
.
perform
(
1
,
untracked_files_for_uploads
.
last
.
id
)
end
.
to
change
{
Upload
.
where
(
model_type:
'Note'
,
model_id:
model
.
id
).
count
}.
from
(
0
).
to
(
1
)
it_behaves_like
'non_markdown_file'
expect
(
Upload
.
where
(
model_type:
'Note'
,
model_id:
model
.
id
).
first
.
attributes
).
to
include
(
expected_upload_attrs
)
end
end
context
'for a user avatar file path'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment