Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e21ce4bc
Commit
e21ce4bc
authored
Jan 31, 2020
by
David O'Regan
Committed by
Kushal Pandya
Jan 31, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix(MVC) Assignee(s) avatar dissapear when opening issue sidebar in board
parent
7b1d23ab
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
31 additions
and
1 deletion
+31
-1
app/assets/javascripts/boards/components/issue_card_inner.vue
...assets/javascripts/boards/components/issue_card_inner.vue
+1
-1
changelogs/unreleased/197894.yml
changelogs/unreleased/197894.yml
+5
-0
spec/frontend/boards/issue_card_spec.js
spec/frontend/boards/issue_card_spec.js
+25
-0
No files found.
app/assets/javascripts/boards/components/issue_card_inner.vue
View file @
e21ce4bc
...
...
@@ -233,7 +233,7 @@ export default {
:key=
"assignee.id"
:link-href=
"assigneeUrl(assignee)"
:img-alt=
"avatarUrlTitle(assignee)"
:img-src=
"assignee.avatar"
:img-src=
"assignee.avatar
|| assignee.avatar_url
"
:img-size=
"24"
class=
"js-no-trigger"
tooltip-placement=
"bottom"
...
...
changelogs/unreleased/197894.yml
0 → 100644
View file @
e21ce4bc
---
title
:
MVC for assignees avatar dissapearing when opening issue sidebar in board
merge_request
:
author
:
Oregand
type
:
fixed
spec/frontend/boards/issue_card_spec.js
View file @
e21ce4bc
...
...
@@ -97,6 +97,9 @@ describe('Issue card component', () => {
issue
:
{
...
wrapper
.
props
(
'
issue
'
),
assignees
:
[
user
],
updateData
(
newData
)
{
Object
.
assign
(
this
,
newData
);
},
},
});
...
...
@@ -118,6 +121,28 @@ describe('Issue card component', () => {
it
(
'
renders avatar
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.board-card-assignee img
'
).
exists
()).
toBe
(
true
);
});
it
(
'
renders the avatar using avatar_url property
'
,
done
=>
{
wrapper
.
props
(
'
issue
'
).
updateData
({
...
wrapper
.
props
(
'
issue
'
),
assignees
:
[
{
id
:
'
1
'
,
name
:
'
test
'
,
state
:
'
active
'
,
username
:
'
test_name
'
,
avatar_url
:
'
test_image_from_avatar_url
'
,
},
],
});
wrapper
.
vm
.
$nextTick
(()
=>
{
expect
(
wrapper
.
find
(
'
.board-card-assignee img
'
).
attributes
(
'
src
'
)).
toBe
(
'
test_image_from_avatar_url?width=24
'
,
);
done
();
});
});
});
describe
(
'
assignee default avatar
'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment