Commit e30e7f47 authored by Peter Leitzen's avatar Peter Leitzen

Merge branch 'leaky-constant-fix-3' into 'master'

Add class stub in query limit helper spec

See merge request gitlab-org/gitlab!31949
parents 4d4ebb3b f3c0c515
......@@ -369,7 +369,6 @@ RSpec/LeakyConstantDeclaration:
- 'spec/services/clusters/applications/check_installation_progress_service_spec.rb'
- 'spec/services/clusters/applications/check_uninstall_progress_service_spec.rb'
- 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb'
- 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb'
RSpec/EmptyLineAfterHook:
Enabled: false
......
---
title: Add class stubs and fix leaky constant alert in query limit helper spec
merge_request: 31949
author: Rajendra Kadam
type: fixed
......@@ -3,16 +3,21 @@
require 'spec_helper'
describe ExceedQueryLimitHelpers do
class TestQueries < ActiveRecord::Base
self.table_name = 'schema_migrations'
end
before do
stub_const('TestQueries', Class.new(ActiveRecord::Base))
stub_const('TestMatcher', Class.new)
TestQueries.class_eval do
self.table_name = 'schema_migrations'
end
class TestMatcher
include ExceedQueryLimitHelpers
TestMatcher.class_eval do
include ExceedQueryLimitHelpers
def expected
ActiveRecord::QueryRecorder.new do
2.times { TestQueries.count }
def expected
ActiveRecord::QueryRecorder.new do
2.times { TestQueries.count }
end
end
end
end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment