Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e323da06
Commit
e323da06
authored
May 10, 2021
by
Daniel Ziegenberg
Committed by
Simon Knox
May 10, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Don't show due dates in red if issue is closed
parent
74da7a21
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
34 additions
and
0 deletions
+34
-0
app/assets/javascripts/vue_shared/components/issue/related_issuable_item.vue
...pts/vue_shared/components/issue/related_issuable_item.vue
+1
-0
changelogs/unreleased/9202-dont-show-due-dates-in-red-if-issue-is-closed.yml
...ed/9202-dont-show-due-dates-in-red-if-issue-is-closed.yml
+4
-0
spec/frontend/vue_shared/components/issue/related_issuable_item_spec.js
...vue_shared/components/issue/related_issuable_item_spec.js
+29
-0
No files found.
app/assets/javascripts/vue_shared/components/issue/related_issuable_item.vue
View file @
e323da06
...
...
@@ -146,6 +146,7 @@ export default {
<span
v-if=
"dueDate"
class=
"order-md-1"
>
<issue-due-date
:date=
"dueDate"
:closed=
"Boolean(closedAt)"
tooltip-placement=
"top"
css-class=
"item-due-date gl-display-flex gl-align-items-center"
/>
...
...
changelogs/unreleased/9202-dont-show-due-dates-in-red-if-issue-is-closed.yml
0 → 100644
View file @
e323da06
title
:
Don't show due dates in red if the issue is closed
merge_request
:
57647
author
:
Daniel Ziegenberg <daniel@ziegenberg.at>
type
:
fixed
spec/frontend/vue_shared/components/issue/related_issuable_item_spec.js
View file @
e323da06
...
...
@@ -132,6 +132,35 @@ describe('RelatedIssuableItem', () => {
it
(
'
renders due date component with correct due date
'
,
()
=>
{
expect
(
wrapper
.
find
(
IssueDueDate
).
props
(
'
date
'
)).
toBe
(
props
.
dueDate
);
});
it
(
'
does not render red icon for overdue issue that is closed
'
,
async
()
=>
{
mountComponent
({
props
:
{
...
props
,
closedAt
:
'
2018-12-01T00:00:00.00Z
'
,
},
});
await
wrapper
.
vm
.
$nextTick
();
expect
(
wrapper
.
find
(
IssueDueDate
).
props
(
'
closed
'
)).
toBe
(
true
);
});
it
(
'
should not contain the `.text-danger` css class for overdue issue that is closed
'
,
async
()
=>
{
mountComponent
({
props
:
{
...
props
,
closedAt
:
'
2018-12-01T00:00:00.00Z
'
,
},
});
await
wrapper
.
vm
.
$nextTick
();
expect
(
wrapper
.
find
(
IssueDueDate
).
find
(
'
.board-card-info-icon
'
).
classes
(
'
text-danger
'
)).
toBe
(
false
,
);
expect
(
wrapper
.
find
(
IssueDueDate
).
find
(
'
.board-card-info-text
'
).
classes
(
'
text-danger
'
)).
toBe
(
false
,
);
});
});
describe
(
'
token assignees
'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment