Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e418a0d0
Commit
e418a0d0
authored
Mar 22, 2021
by
Serena Fang
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Simplify check permissions method
parent
2826c64f
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
11 deletions
+4
-11
app/controllers/projects/settings/access_tokens_controller.rb
...controllers/projects/settings/access_tokens_controller.rb
+4
-11
No files found.
app/controllers/projects/settings/access_tokens_controller.rb
View file @
e418a0d0
...
...
@@ -6,9 +6,9 @@ module Projects
include
ProjectsHelper
layout
'project_settings'
before_action
->
{
check_permission
(
:read
)
},
only:
[
:index
]
before_action
->
{
check_permission
(
:destroy
)
},
only:
[
:revoke
]
before_action
->
{
check_permission
(
:create
)
},
only:
[
:create
]
before_action
->
{
check_permission
(
:read
_resource_access_tokens
)
},
only:
[
:index
]
before_action
->
{
check_permission
(
:destroy
_resource_access_tokens
)
},
only:
[
:revoke
]
before_action
->
{
check_permission
(
:create
_resource_access_tokens
)
},
only:
[
:create
]
feature_category
:authentication_and_authorization
...
...
@@ -46,14 +46,7 @@ module Projects
private
def
check_permission
(
action
)
case
action
when
:read
render_404
unless
can?
(
current_user
,
:read_resource_access_tokens
,
@project
)
when
:destroy
access_denied!
unless
can?
(
current_user
,
:destroy_resource_access_tokens
,
@project
)
when
:create
access_denied!
unless
can?
(
current_user
,
:create_resource_access_tokens
,
@project
)
end
render_404
unless
can?
(
current_user
,
action
,
@project
)
end
def
create_params
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment