Commit e41d5ef4 authored by Drew Blessing's avatar Drew Blessing

Merge branch 'revert-9b9a31c7' into 'master'

Revert "Merge branch 'fix_stale_last_owner' into 'master'"

This reverts merge request !529

Accidentally merged my own MR before review. Reverting and resubmitting. 

See merge request !530
parents 9b9a31c7 5c8b211c
......@@ -3,9 +3,6 @@ Please view this file on the master branch, on stable branches it's out of date.
v 8.10.0 (unreleased)
- Rename Git Hooks to Push Rules
v 8.9.5
- Prevent stale data in LDAP group sync last owner check.
v 8.9.4
- Improve how File Lock feature works with nested items. !497
......
......@@ -304,11 +304,6 @@ module Gitlab
next
end
# Since we're removing users in this loop, `group.reload`
# before checking `last_owner?` to prevent stale owner information.
# Without a reload, this check would return a false negative.
group.reload
# Check and update the access level. If `desired_access` is `nil`
# we need to delete the user from the group.
if desired_access.present?
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment