Apply 9 suggestion(s) to 2 file(s)

doc/development/usage_ping/metrics_dictionary.md

@@ -37,7 +37,7 @@ Each metric is defined in a separate YAML file consisting of a number of fields:
 | `status`            | yes      | `string`; [status](#metric-statuses) of the metric, may be set to `data_available`, `implemented`, `not_used`, `deprecated`, `removed`. |
 | `time_frame`        | yes      | `string`; may be set to a value like `7d`, `28d`, `all`, `none`. |
 | `data_source`       | yes      | `string`; may be set to a value like `database`, `redis`, `redis_hll`, `prometheus`, `ruby`. |
-| `instrumentation_class` | no   | `string`; [the class which implements the metric](metrics_instrumentation.md).  |
+| `instrumentation_class` | no   | `string`; [the class that implements the metric](metrics_instrumentation.md).  |
 | `distribution`      | yes      | `array`; may be set to one of `ce, ee` or `ee`. The [distribution](https://about.gitlab.com/handbook/marketing/strategic-marketing/tiers/#definitions) where the tracked feature is available.  |
 | `tier`              | yes      | `array`; may be set to one of `free, premium, ultimate`, `premium, ultimate` or `ultimate`. The [tier]( https://about.gitlab.com/handbook/marketing/strategic-marketing/tiers/) where the tracked feature is available. |
 | `milestone`         | no       | The milestone when the metric is introduced. |

doc/development/usage_ping/metrics_instrumentation.md

@@ -4,35 +4,36 @@ group: Product Intelligence
 info: To determine the technical writer assigned to the Stage/Group associated with this page, see https://about.gitlab.com/handbook/engineering/ux/technical-writing/#assignments
 ---
 
-# Metrics Instrumentation Guide
+# Metrics instrumentation guide
 
-This guide describes how to develop Usage Ping metrics using metrics instrumentation
+This guide describes how to develop Usage Ping metrics using metrics instrumentation.
 
 ## Nomenclature
 
-- **Instrumentation class**
-  A class wich inherits one of the metrics class `DatabaseMetric`, `RedisHLLMetric` or `GenericMetric`
-  and implements the logic for calculating the value for a Usage Ping metric.
+- **Instrumentation class**:
+  - Inherits one of the metric classes: `DatabaseMetric`, `RedisHLLMetric` or `GenericMetric`.
+  - Implements the logic that calculates the value for a Usage Ping metric.
 
 - **Metric definition**
   The Usage Data metric YAML definition.
 
-- **Hardening**
-  Hardening a method is the process which makes sure that the method fails safe, returning a fallback value like -1.
+- **Hardening**:
+  Hardening a method is the process that ensures the method fails safe, returning a fallback value like -1.
 
 ## How it works
 
-Metric definiton has the [`instrumentation_class`](metrics_dictionary.md) field which can be set to a class.
+A metric definition has the [`instrumentation_class`](metrics_dictionary.md) field, which can be set to a class.
 
-The defined instrumentation class should have one of the existing metric classes: `DatabaseMetric`, `RedisHLLMetric` or `GenericMetric`.
+The defined instrumentation class should have one of the existing metric classes: `DatabaseMetric`, `RedisHLLMetric`, or `GenericMetric`.
 
-Using the instrumentation classes it is ensured that metrics could fail safe, individualy without breaking the entire Usage Ping generation.
+Using the instrumentation classes ensures that metrics can fail safe individually, without breaking the entire 
+ process of Usage Ping generation.
 
-We have built a DSL to define the metrics instrumentation.
+We have built a domain-specific language (DSL) to define the metrics instrumentation.
 
 ## Database metrics
 
-[Example of merge request adding database metrics](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60022)
+[Example of a merge request that adds a database metric](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60022).
 
 ```ruby
 module Gitlab
@@ -52,7 +53,7 @@ end
 
 ## Redis HyperLogLog metrics
 
-[Example of merge reequest adding `RedisHLL` metric](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60089/diffs)
+[Example of a merge request that adds a `RedisHLL` metric](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60089/diffs).
 
 ```ruby
 module Gitlab
@@ -70,7 +71,7 @@ end
 
 ## Generic metrics
 
-[Example of merge request adding generic metric](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60256)
+[Example of a merge request that adds a generic metric](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60256).
 
 ```ruby
 module Gitlab