Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e45064e8
Commit
e45064e8
authored
Aug 15, 2016
by
Clement Ho
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix diff comments inverted toggle bug
parent
06e3bb9f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
2 deletions
+6
-2
CHANGELOG
CHANGELOG
+1
-0
app/assets/javascripts/application.js
app/assets/javascripts/application.js
+5
-2
No files found.
CHANGELOG
View file @
e45064e8
...
@@ -85,6 +85,7 @@ v 8.11.0 (unreleased)
...
@@ -85,6 +85,7 @@ v 8.11.0 (unreleased)
- Allow branch names ending with .json for graph and network page !5579 (winniehell)
- Allow branch names ending with .json for graph and network page !5579 (winniehell)
- Add the `sprockets-es6` gem
- Add the `sprockets-es6` gem
- Improve OAuth2 client documentation (muteor)
- Improve OAuth2 client documentation (muteor)
- Fix diff comments inverted toggle bug (ClemMakesApps)
- Multiple trigger variables show in separate lines (Katarzyna Kobierska Ula Budziszewska)
- Multiple trigger variables show in separate lines (Katarzyna Kobierska Ula Budziszewska)
- Profile requests when a header is passed
- Profile requests when a header is passed
- Avoid calculation of line_code and position for _line partial when showing diff notes on discussion tab.
- Avoid calculation of line_code and position for _line partial when showing diff notes on discussion tab.
...
...
app/assets/javascripts/application.js
View file @
e45064e8
...
@@ -223,8 +223,11 @@
...
@@ -223,8 +223,11 @@
return
$
(
'
.navbar-toggle
'
).
toggleClass
(
'
active
'
);
return
$
(
'
.navbar-toggle
'
).
toggleClass
(
'
active
'
);
});
});
$body
.
on
(
"
click
"
,
"
.js-toggle-diff-comments
"
,
function
(
e
)
{
$body
.
on
(
"
click
"
,
"
.js-toggle-diff-comments
"
,
function
(
e
)
{
$
(
this
).
toggleClass
(
'
active
'
);
var
$this
=
$
(
this
);
$
(
this
).
closest
(
"
.diff-file
"
).
find
(
"
.notes_holder
"
).
toggle
();
var
showComments
=
$this
.
hasClass
(
'
active
'
);
$this
.
toggleClass
(
'
active
'
);
$this
.
closest
(
"
.diff-file
"
).
find
(
"
.notes_holder
"
).
toggle
(
showComments
);
return
e
.
preventDefault
();
return
e
.
preventDefault
();
});
});
$document
.
off
(
"
click
"
,
'
.js-confirm-danger
'
);
$document
.
off
(
"
click
"
,
'
.js-confirm-danger
'
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment