Refactor group/edit LDAP sync page

app/controllers/groups/ldap_group_links_controller.rb

@@ -2,6 +2,9 @@ class Groups::LdapGroupLinksController < ApplicationController
   before_action :group
   before_action :authorize_admin_group!
 
+  def index
+  end
+
   def create
     ldap_group_link = @group.ldap_group_links.build(ldap_group_link_params)
     if ldap_group_link.save

app/views/admin/groups/_form.html.haml

@@ -59,3 +59,4 @@
 - if @group.persisted?
   %h3.page-title LDAP Synchronizations
   = render 'ldap_group_links/form', group: @group
+  = render 'ldap_group_links/ldap_group_links', group: @group

app/views/groups/_settings_nav.html.haml

@@ -7,4 +7,8 @@
     = link_to projects_group_path(@group) do
       %i.icon-folder-close
       Projects
+  = nav_link(controller: [:groups, :ldap_group_links]) do
+    = link_to group_ldap_group_links_path(@group) do
+      %i.icon-exchange
+      LDAP Sync
 

app/views/groups/ldap_group_links/index.html.haml

+.row
+  .col-md-2= render 'groups/settings_nav'
+  .col-md-10
+    %h3.page-title LDAP Synchronizations
+    = render 'ldap_group_links/form', group: @group
+    = render 'ldap_group_links/ldap_group_links', group: @group
+

app/views/ldap_group_links/_form.html.haml

@@ -24,6 +24,4 @@
               You can manage permission levels for individual group members in the Members tab.
 
       .form-actions
-        = f.submit 'Add Synchronization', class: "btn btn-create"
-
-  = render partial: 'ldap_group_links/ldap_group_links', locals: { group: group }
\ No newline at end of file
+        = f.submit 'Add Synchronization', class: "btn btn-create"
\ No newline at end of file

config/routes.rb

@@ -167,7 +167,7 @@ Gitlab::Application.routes.draw do
 
     resources :users_groups, only: [:create, :update, :destroy]
     scope module: :groups do
-      resources :ldap_group_links, only: [:create, :destroy]
+      resources :ldap_group_links, only: [:index, :create, :destroy]
       resource :avatar, only: [:destroy]
       resources :milestones
     end