Clean up HAML, remove i18n where not needed

ee/app/views/projects/security/vulnerabilities/show.html.haml

@@ -29,21 +29,18 @@
           %h3= _('Location')
           %ul
             %li
-              - link_text = _("%{file}") % { file: location['file'] }
-              - offset = _('')
-              - branch = _("%{branch}") % { branch: @vulnerability.finding.pipelines&.last&.sha || @vulnerability.project.default_branch }
-              - if location['start_line']
-                - link_text = _("%{link_text}:%{line}") % { link_text: link_text, line: location['start_line'] }
-                - offset = _("#L%{start_line}") % { start_line: location['start_line'] }
-              = _('File:')
+              - link_text = "#{location['file']}:#{location['start_line']}"
+              - offset = location['start_line'] ? "#L#{location['start_line']}" : ''
+              - branch = @vulnerability.finding.pipelines&.last&.sha || @vulnerability.project.default_branch
+              = _("File:")
               %a{ href: project_blob_path(@project, tree_join(branch, location['file'])) + offset,
                 target: '_blank', rel: 'noopener noreferrer' }= link_text
             - if location['class']
-              %li= _("Class: %{className}") % { className: location['class'] }
+              %li= _("Class: ") + location['class']
             - if location['method']
               %li
-                = _('Method:')
-                %code= _("%{method}") % { method: location['method'] }
+                = _("Method:")
+                %code= location['method']
 
         - if @vulnerability.finding.links.any?
           %h3= _("Links")

locale/gitlab.pot

@@ -71,9 +71,6 @@ msgstr ""
 msgid "\"%{path}\" did not exist on \"%{ref}\""
 msgstr ""
 
-msgid "#L%{start_line}"
-msgstr ""
-
 msgid "%d changed file"
 msgid_plural "%d changed files"
 msgstr[0] ""
@@ -228,9 +225,6 @@ msgstr ""
 msgid "%{authorsName}'s thread"
 msgstr ""
 
-msgid "%{branch}"
-msgstr ""
-
 msgid "%{commit_author_link} authored %{commit_timeago}"
 msgstr ""
 
@@ -311,9 +305,6 @@ msgstr ""
 msgid "%{filePath} deleted"
 msgstr ""
 
-msgid "%{file}"
-msgstr ""
-
 msgid "%{firstLabel} +%{labelCount} more"
 msgstr ""
 
@@ -359,9 +350,6 @@ msgstr ""
 msgid "%{link_start}Read more%{link_end} about role permissions"
 msgstr ""
 
-msgid "%{link_text}:%{line}"
-msgstr ""
-
 msgid "%{link} can be used for binding events when something is happening within the project."
 msgstr ""
 
@@ -377,9 +365,6 @@ msgstr ""
 msgid "%{mergeLength}/%{usersLength} can merge"
 msgstr ""
 
-msgid "%{method}"
-msgstr ""
-
 msgid "%{mrText}, this issue will be closed automatically."
 msgstr ""
 
@@ -3968,7 +3953,7 @@ msgstr ""
 msgid "Class"
 msgstr ""
 
-msgid "Class: %{className}"
+msgid "Class: "
 msgstr ""
 
 msgid "Classification Label (optional)"