Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e5fe9186
Commit
e5fe9186
authored
Jan 29, 2019
by
Fernando Arias
Committed by
Clement Ho
Jan 29, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Btn group secure group dashboard
parent
3263a096
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
27 additions
and
14 deletions
+27
-14
app/assets/stylesheets/framework/buttons.scss
app/assets/stylesheets/framework/buttons.scss
+4
-0
ee/app/assets/javascripts/security_dashboard/components/vulnerability_action_buttons.vue
...ity_dashboard/components/vulnerability_action_buttons.vue
+11
-7
ee/changelogs/unreleased/btn-group-secure-group-dashboard.yml
...hangelogs/unreleased/btn-group-secure-group-dashboard.yml
+5
-0
ee/spec/javascripts/security_dashboard/components/vulnerability_action_buttons_spec.js
...dashboard/components/vulnerability_action_buttons_spec.js
+4
-4
locale/gitlab.pot
locale/gitlab.pot
+3
-3
No files found.
app/assets/stylesheets/framework/buttons.scss
View file @
e5fe9186
...
...
@@ -42,6 +42,10 @@
color
:
$text
;
border-color
:
$border
;
&
.btn-border-color
{
border-color
:
$border-color
;
}
>
.icon
{
color
:
$text
;
}
...
...
ee/app/assets/javascripts/security_dashboard/components/vulnerability_action_buttons.vue
View file @
e5fe9186
...
...
@@ -61,13 +61,13 @@ export default {
</
script
>
<
template
>
<div>
<div
class=
"btn-group"
>
<button
key=
"more-info"
v-gl-tooltip
:aria-label=
"s__('Security Reports|More info')"
:title=
"s__('Security Reports|More info')"
class=
"btn btn-
secondary
btn-icon js-more-info"
class=
"btn btn-
inverted btn-info btn-secondary btn-border-color
btn-icon js-more-info"
type=
"button"
@
click=
"openModal(
{ vulnerability })"
>
...
...
@@ -80,7 +80,7 @@ export default {
:aria-label=
"s__('Security Reports|Create issue')"
:loading=
"isCreatingIssue"
:title=
"s__('Security Reports|Create issue')"
container-class=
"btn btn-inverted btn-success
prepend-left-8
js-create-issue"
container-class=
"btn btn-inverted btn-success
btn-border-color
js-create-issue"
type=
"button"
@
click=
"handleCreateIssue"
>
...
...
@@ -90,12 +90,16 @@ export default {
<loading-button
v-if=
"isDismissed"
key=
"revert-dismissal"
:label=
"s__('Security Reports|Revert dismissal')"
v-gl-tooltip
:aria-label=
"s__('Security Reports|Undo dismiss')"
:loading=
"isDismissingVulnerability"
container-class=
"btn btn-inverted btn-warning prepend-left-8 js-revert-dismissal"
:title=
"s__('Security Reports|Undo dismiss')"
container-class=
"btn btn-inverted btn-warning btn-border-color js-revert-dismissal"
type=
"button"
@
click=
"handleRevertDismissal"
/>
>
<icon
name=
"repeat"
/>
</loading-button>
<loading-button
v-else
key=
"dismiss-vulnerability"
...
...
@@ -103,7 +107,7 @@ export default {
:aria-label=
"s__('Security Reports|Dismiss vulnerability')"
:loading=
"isDismissingVulnerability"
:title=
"s__('Security Reports|Dismiss vulnerability')"
container-class=
"btn btn-inverted btn-warning
prepend-left-8
js-dismiss-vulnerability"
container-class=
"btn btn-inverted btn-warning
btn-border-color
js-dismiss-vulnerability"
type=
"button"
@
click=
"handleDismissVulnerability"
>
...
...
ee/changelogs/unreleased/btn-group-secure-group-dashboard.yml
0 → 100644
View file @
e5fe9186
---
title
:
Convert buttons to button group on Group Security Dashboard
merge_request
:
9220
author
:
type
:
changed
ee/spec/javascripts/security_dashboard/components/vulnerability_action_buttons_spec.js
View file @
e5fe9186
...
...
@@ -36,8 +36,8 @@ describe('Security Dashboard Action Buttons', () => {
vm
.
$destroy
();
});
it
(
'
should render three buttons
'
,
()
=>
{
expect
(
vm
.
$el
.
querySelectorAll
(
'
.btn
'
)).
toHaveLength
(
3
);
it
(
'
should render three buttons
in a button group
'
,
()
=>
{
expect
(
vm
.
$el
.
querySelectorAll
(
'
.btn
-group .btn
'
)).
toHaveLength
(
3
);
});
describe
(
'
More Info Button
'
,
()
=>
{
...
...
@@ -138,8 +138,8 @@ describe('Security Dashboard Action Buttons', () => {
vm
.
$destroy
();
});
it
(
'
should render two buttons
'
,
()
=>
{
expect
(
vm
.
$el
.
querySelectorAll
(
'
.btn
'
)).
toHaveLength
(
2
);
it
(
'
should render two buttons
in a button group
'
,
()
=>
{
expect
(
vm
.
$el
.
querySelectorAll
(
'
.btn
-group .btn
'
)).
toHaveLength
(
2
);
});
it
(
'
should not render the dismiss vulnerability button
'
,
()
=>
{
...
...
locale/gitlab.pot
View file @
e5fe9186
...
...
@@ -8103,9 +8103,6 @@ msgstr ""
msgid "Security Reports|No Vulnerabilities"
msgstr ""
msgid "Security Reports|Revert dismissal"
msgstr ""
msgid "Security Reports|Security dashboard documentation"
msgstr ""
...
...
@@ -8121,6 +8118,9 @@ msgstr ""
msgid "Security Reports|There was an error reverting this dismissal."
msgstr ""
msgid "Security Reports|Undo dismiss"
msgstr ""
msgid "Security Reports|We've found no vulnerabilities for your group"
msgstr ""
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment