Merge branch '336574-remove-ff-pages_smart_check_outdated_sha' into 'master'

Remove pages_smart_check_outdated_sha feature flag

See merge request gitlab-org/gitlab!71530

app/services/projects/update_pages_service.rb

@@ -136,13 +136,11 @@ module Projects
     def validate_outdated_sha!
       return if latest?
 
-      if Feature.enabled?(:pages_smart_check_outdated_sha, project, default_enabled: :yaml)
-        # use pipeline_id in case the build is retried
-        last_deployed_pipeline_id = project.pages_metadatum&.pages_deployment&.ci_build&.pipeline_id
+      # use pipeline_id in case the build is retried
+      last_deployed_pipeline_id = project.pages_metadatum&.pages_deployment&.ci_build&.pipeline_id
 
-        return unless last_deployed_pipeline_id
-        return if last_deployed_pipeline_id <= build.pipeline_id
-      end
+      return unless last_deployed_pipeline_id
+      return if last_deployed_pipeline_id <= build.pipeline_id
 
       raise InvalidStateError, 'build SHA is outdated for this ref'
     end

config/feature_flags/development/pages_smart_check_outdated_sha.yml

----
-name: pages_smart_check_outdated_sha
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/67303
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/336574
-milestone: '14.2'
-type: development
-group: group::release
-default_enabled: false

spec/services/projects/update_pages_service_spec.rb

@@ -173,14 +173,6 @@ RSpec.describe Projects::UpdatePagesService do
 
         include_examples 'successfully deploys'
 
-        context 'when pages_smart_check_outdated_sha feature flag is disabled' do
-          before do
-            stub_feature_flags(pages_smart_check_outdated_sha: false)
-          end
-
-          include_examples 'fails with outdated reference message'
-        end
-
         context 'when old deployment present' do
           before do
             old_build = create(:ci_build, pipeline: old_pipeline, ref: 'HEAD')
@@ -189,14 +181,6 @@ RSpec.describe Projects::UpdatePagesService do
           end
 
           include_examples 'successfully deploys'
-
-          context 'when pages_smart_check_outdated_sha feature flag is disabled' do
-            before do
-              stub_feature_flags(pages_smart_check_outdated_sha: false)
-            end
-
-            include_examples 'fails with outdated reference message'
-          end
         end
 
         context 'when newer deployment present' do