Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e74fd32c
Commit
e74fd32c
authored
Jan 07, 2021
by
Kyle Wiebers
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update the Danger status docs after recent changes
See
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/50172
parent
aef2c84d
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
3 deletions
+4
-3
doc/development/code_review.md
doc/development/code_review.md
+4
-3
No files found.
doc/development/code_review.md
View file @
e74fd32c
...
@@ -69,11 +69,12 @@ It picks reviewers and maintainers from the list at the
...
@@ -69,11 +69,12 @@ It picks reviewers and maintainers from the list at the
[
engineering projects
](
https://about.gitlab.com/handbook/engineering/projects/
)
[
engineering projects
](
https://about.gitlab.com/handbook/engineering/projects/
)
page, with these behaviors:
page, with these behaviors:
1.
It doesn't pick people whose
[
GitLab status
](
../user/profile/index.md#current-status
)
1.
It doesn't pick people whose Slack or
[
GitLab status
](
../user/profile/index.md#current-status
)
:
contains the string 'OOO', or the emoji is
`:palm_tree:`
or
`:beach:`
.
-
contains the string 'OOO', 'PTO', 'Parental Leave', or 'Friends and Family'
-
emoji is
`:palm_tree:`
,
`:beach:`
,
`:beach_umbrella:`
,
`:beach_with_umbrella:`
,
`:ferris_wheel:`
,
`:thermometer:`
,
`:face_with_thermometer:`
,
`:red_circle:`
,
`:bulb:`
,
`:sun_with_face:`
.
1.
[
Trainee maintainers
](
https://about.gitlab.com/handbook/engineering/workflow/code-review/#trainee-maintainer
)
1.
[
Trainee maintainers
](
https://about.gitlab.com/handbook/engineering/workflow/code-review/#trainee-maintainer
)
are three times as likely to be picked as other reviewers.
are three times as likely to be picked as other reviewers.
1.
People whose
[
GitLab status
](
../user/profile/index.md#current-status
)
emoji
1.
Team members whose Slack or
[
GitLab status
](
../user/profile/index.md#current-status
)
emoji
is
`:large_blue_circle:`
are more likely to be picked. This applies to both reviewers and trainee maintainers.
is
`:large_blue_circle:`
are more likely to be picked. This applies to both reviewers and trainee maintainers.
-
Reviewers with
`:large_blue_circle:`
are two times as likely to be picked as other reviewers.
-
Reviewers with
`:large_blue_circle:`
are two times as likely to be picked as other reviewers.
-
Trainee maintainers with
`:large_blue_circle:`
are four times as likely to be picked as other reviewers.
-
Trainee maintainers with
`:large_blue_circle:`
are four times as likely to be picked as other reviewers.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment