Merge branch '195309-remove-special-user-action-buttons' into 'master'

Remove action buttons for special users

See merge request gitlab-org/gitlab!27162

app/views/admin/users/_user.html.haml

@@ -14,51 +14,52 @@
       = _('Last activity')
     .table-mobile-content
       = user.last_activity_on.nil? ? _('Never') : l(user.last_activity_on, format: :admin)
-  .table-section.section-20.table-button-footer
-    .table-action-buttons
-      = link_to _('Edit'), edit_admin_user_path(user), id: "edit_#{dom_id(user)}", class: 'btn btn-default'
-      - unless user == current_user
-        %button.dropdown-new.btn.btn-default{ type: 'button', data: { toggle: 'dropdown' } }
-          = sprite_icon('settings')
-          = sprite_icon('chevron-down')
-        %ul.dropdown-menu.dropdown-menu-right
-          %li.dropdown-header
-            = _('Settings')
-            %li
-              - if user.ldap_blocked?
-                %span.small
-                  = s_('AdminUsers|Cannot unblock LDAP blocked users')
-              - elsif user.blocked?
-                = link_to _('Unblock'), unblock_admin_user_path(user), method: :put
-              - else
-                %button.btn{ data: { 'gl-modal-action': 'block',
-                  url: block_admin_user_path(user),
-                  username: sanitize_name(user.name) } }
-                  = s_('AdminUsers|Block')
-            - if user.can_be_deactivated?
+  - unless user.internal?
+    .table-section.section-20.table-button-footer
+      .table-action-buttons
+        = link_to _('Edit'), edit_admin_user_path(user), id: "edit_#{dom_id(user)}", class: 'btn btn-default'
+        - unless user == current_user
+          %button.dropdown-new.btn.btn-default{ type: 'button', data: { toggle: 'dropdown' } }
+            = sprite_icon('settings')
+            = sprite_icon('chevron-down')
+          %ul.dropdown-menu.dropdown-menu-right
+            %li.dropdown-header
+              = _('Settings')
               %li
-                %button.btn{ data: { 'gl-modal-action': 'deactivate',
-                  url: deactivate_admin_user_path(user),
-                  username: sanitize_name(user.name) } }
-                  = s_('AdminUsers|Deactivate')
-            - elsif user.deactivated?
-              %li
-                = link_to _('Activate'), activate_admin_user_path(user), method: :put
-            - if user.access_locked?
-              %li
-                = link_to _('Unlock'), unlock_admin_user_path(user), method: :put, data: { confirm: _('Are you sure?') }
-          - if can?(current_user, :destroy_user, user)
-            %li.divider
-            - if user.can_be_removed?
-              %li
-                %button.delete-user-button.btn.text-danger{ data: { 'gl-modal-action': 'delete',
-                  delete_user_url: admin_user_path(user),
-                  block_user_url: block_admin_user_path(user),
-                  username: sanitize_name(user.name) } }
-                  = s_('AdminUsers|Delete user')
-              %li
-                %button.delete-user-button.btn.text-danger{ data: { 'gl-modal-action': 'delete-with-contributions',
-                  delete_user_url: admin_user_path(user, hard_delete: true),
-                  block_user_url: block_admin_user_path(user),
-                  username: sanitize_name(user.name) } }
-                  = s_('AdminUsers|Delete user and contributions')
+                - if user.ldap_blocked?
+                  %span.small
+                    = s_('AdminUsers|Cannot unblock LDAP blocked users')
+                - elsif user.blocked?
+                  = link_to _('Unblock'), unblock_admin_user_path(user), method: :put
+                - else
+                  %button.btn{ data: { 'gl-modal-action': 'block',
+                    url: block_admin_user_path(user),
+                    username: sanitize_name(user.name) } }
+                    = s_('AdminUsers|Block')
+              - if user.can_be_deactivated?
+                %li
+                  %button.btn{ data: { 'gl-modal-action': 'deactivate',
+                    url: deactivate_admin_user_path(user),
+                    username: sanitize_name(user.name) } }
+                    = s_('AdminUsers|Deactivate')
+              - elsif user.deactivated?
+                %li
+                  = link_to _('Activate'), activate_admin_user_path(user), method: :put
+              - if user.access_locked?
+                %li
+                  = link_to _('Unlock'), unlock_admin_user_path(user), method: :put, data: { confirm: _('Are you sure?') }
+            - if can?(current_user, :destroy_user, user)
+              %li.divider
+              - if user.can_be_removed?
+                %li
+                  %button.delete-user-button.btn.text-danger{ data: { 'gl-modal-action': 'delete',
+                    delete_user_url: admin_user_path(user),
+                    block_user_url: block_admin_user_path(user),
+                    username: sanitize_name(user.name) } }
+                    = s_('AdminUsers|Delete user')
+                %li
+                  %button.delete-user-button.btn.text-danger{ data: { 'gl-modal-action': 'delete-with-contributions',
+                    delete_user_url: admin_user_path(user, hard_delete: true),
+                    block_user_url: block_admin_user_path(user),
+                    username: sanitize_name(user.name) } }
+                    = s_('AdminUsers|Delete user and contributions')

changelogs/unreleased/195309-remove-special-user-action-buttons.yml

+---
+title: Hide admin user actions for ghost and bot users
+merge_request: 27162
+author:
+type: fixed

spec/views/admin/users/_user.html.haml_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'admin/users/_user.html.haml' do
+  before do
+    allow(view).to receive(:user).and_return(user)
+  end
+
+  context 'internal users' do
+    context 'when showing a `Ghost User`' do
+      let(:user) { create(:user, ghost: true) }
+
+      it 'does not render action buttons' do
+        render
+
+        expect(rendered).not_to have_selector('.table-action-buttons')
+      end
+    end
+
+    context 'when showing a `Bot User`' do
+      let(:user) { create(:user, user_type: :alert_bot) }
+
+      it 'does not render action buttons' do
+        render
+
+        expect(rendered).not_to have_selector('.table-action-buttons')
+      end
+    end
+  end
+
+  context 'when showing an external user' do
+    let(:user) { create(:user) }
+
+    it 'renders action buttons' do
+      render
+
+      expect(rendered).to have_selector('.table-action-buttons')
+    end
+  end
+end