Merge branch 'issue_34852' into 'master'

fix milestones finder failing spec

Closes #34852

See merge request !12727

app/finders/milestones_finder.rb

@@ -49,7 +49,8 @@ class MilestonesFinder
     if params.has_key?(:order)
       items.reorder(params[:order])
     else
-      items.reorder('due_date ASC')
+      order_statement = Gitlab::Database.nulls_last_order('due_date', 'ASC')
+      items.reorder(order_statement)
     end
   end
 end