Commit e87d58b5 authored by Laura Montemayor's avatar Laura Montemayor Committed by lauraMon

Update descriptions and correct variable

parent c6c58538
...@@ -8,15 +8,15 @@ module Resolvers ...@@ -8,15 +8,15 @@ module Resolvers
argument :iid, GraphQL::ID_TYPE, argument :iid, GraphQL::ID_TYPE,
required: false, required: false,
description: 'IID of the Pipeline, e.g., "1".' description: 'IID of the Pipeline. For example, "1".'
argument :sha, GraphQL::STRING_TYPE, argument :sha, GraphQL::STRING_TYPE,
required: false, required: false,
description: 'SHA of the Pipeline, e.g., "dyd0f15ay83993f5ab66k927w28673882x99100b".' description: 'SHA of the Pipeline. For example, "dyd0f15ay83993f5ab66k927w28673882x99100b".'
def ready?(iid: nil, sha: nil) def ready?(iid: nil, sha: nil)
unless iid.present? ^ sha.present? unless iid.present? ^ sha.present?
raise Gitlab::Graphql::Errors::ArgumentError, 'Provide either an iid or sha' raise Gitlab::Graphql::Errors::ArgumentError, 'Provide one of an IID or SHA'
end end
super super
...@@ -25,13 +25,13 @@ module Resolvers ...@@ -25,13 +25,13 @@ module Resolvers
def resolve(iid: nil, sha: nil) def resolve(iid: nil, sha: nil)
if iid if iid
BatchLoader::GraphQL.for(iid).batch(key: project) do |iids, loader, args| BatchLoader::GraphQL.for(iid).batch(key: project) do |iids, loader, args|
finder = ::Ci::PipelinesFinder.new(project, context[:current_user], iids: iids) finder = ::Ci::PipelinesFinder.new(project, current_user, iids: iids)
finder.execute.each { |pipeline| loader.call(pipeline.iid.to_s, pipeline) } finder.execute.each { |pipeline| loader.call(pipeline.iid.to_s, pipeline) }
end end
else else
BatchLoader::GraphQL.for(sha).batch(key: project) do |shas, loader, args| BatchLoader::GraphQL.for(sha).batch(key: project) do |shas, loader, args|
finder = ::Ci::PipelinesFinder.new(project, context[:current_user], shas: sha) finder = ::Ci::PipelinesFinder.new(project, current_user, shas: shas)
finder.execute.each { |pipeline| loader.call(pipeline.sha.to_s, pipeline) } finder.execute.each { |pipeline| loader.call(pipeline.sha.to_s, pipeline) }
end end
......
--- ---
title: Updates ProjectPipelineResolver to use sha or iid title: Updates ProjectPipelineResolver to use SHA as well as IID
merge_request: 54471 merge_request: 54471
author: author:
type: changed type: changed
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment