Commit e9ed3588 authored by Eulyeon Ko's avatar Eulyeon Ko

Use classic boards for some board/sidebar tests

Use classic boards for the following feature tests
by stubbing feature flag graphql_board_lists to false.

1. sidebar_spec.rb and its related variants

Temporarily stub feature flag graphql_board_lists
for the following specs while we investigate
their flaky runs in CI

2. sub_group_project_spec.rb

Feature not implemented in graphql-based boards

3. multi_select_spec.rb

Feature not implemented in graphql-based boards

4. add_issues_modal_spec.rb (ce and ee)

This feature is being deprecated behind a feature flag
(:add_issues_button) and should not be included
in graphql-based boards
parent c63f962e
...@@ -12,6 +12,7 @@ RSpec.describe 'Issue Boards add issue modal', :js do ...@@ -12,6 +12,7 @@ RSpec.describe 'Issue Boards add issue modal', :js do
let!(:issue) { create(:issue, project: project, title: 'abc', description: 'def') } let!(:issue) { create(:issue, project: project, title: 'abc', description: 'def') }
before do before do
stub_feature_flags(graphql_board_lists: false)
stub_feature_flags(add_issues_button: true) stub_feature_flags(add_issues_button: true)
project.add_maintainer(user) project.add_maintainer(user)
......
...@@ -22,6 +22,7 @@ RSpec.describe 'Issue Boards', :js do ...@@ -22,6 +22,7 @@ RSpec.describe 'Issue Boards', :js do
let(:card2) { find('.board:nth-child(2)').find('.board-card:nth-child(1)') } let(:card2) { find('.board:nth-child(2)').find('.board-card:nth-child(1)') }
before do before do
stub_feature_flags(graphql_board_lists: false)
stub_licensed_features(multiple_issue_assignees: true) stub_licensed_features(multiple_issue_assignees: true)
project.add_maintainer(user) project.add_maintainer(user)
......
...@@ -81,7 +81,7 @@ RSpec.describe 'Filter issues by iteration', :js do ...@@ -81,7 +81,7 @@ RSpec.describe 'Filter issues by iteration', :js do
before do before do
# iterationWildCardId is not yet supported by graphQL https://gitlab.com/gitlab-org/gitlab/-/issues/300115 # iterationWildCardId is not yet supported by graphQL https://gitlab.com/gitlab-org/gitlab/-/issues/300115
stub_feature_flags(graphql_board_lists: false) stub_feature_flags(graphql_board_lists: false)
visit page_path visit page_path
page.within('.filtered-search-wrapper') do page.within('.filtered-search-wrapper') do
......
...@@ -14,6 +14,7 @@ RSpec.describe 'Issue Boards add issue modal', :js do ...@@ -14,6 +14,7 @@ RSpec.describe 'Issue Boards add issue modal', :js do
let!(:issue2) { create(:issue, project: project, title: 'hij', description: 'klm') } let!(:issue2) { create(:issue, project: project, title: 'hij', description: 'klm') }
before do before do
stub_feature_flags(graphql_board_lists: false)
project.add_maintainer(user) project.add_maintainer(user)
sign_in(user) sign_in(user)
......
...@@ -41,6 +41,10 @@ RSpec.describe 'Multi Select Issue', :js do ...@@ -41,6 +41,10 @@ RSpec.describe 'Multi Select Issue', :js do
before do before do
project.add_maintainer(user) project.add_maintainer(user)
# multi-drag disabled with feature flag for now
# https://gitlab.com/gitlab-org/gitlab/-/issues/289797
stub_feature_flags(graphql_board_lists: false)
sign_in(user) sign_in(user)
end end
......
...@@ -17,6 +17,8 @@ RSpec.describe 'Project issue boards sidebar assignee', :js do ...@@ -17,6 +17,8 @@ RSpec.describe 'Project issue boards sidebar assignee', :js do
let(:card) { find('.board:nth-child(2)').first('.board-card') } let(:card) { find('.board:nth-child(2)').first('.board-card') }
before do before do
stub_feature_flags(graphql_board_lists: false)
project.add_maintainer(user) project.add_maintainer(user)
sign_in(user) sign_in(user)
......
...@@ -17,6 +17,8 @@ RSpec.describe 'Project issue boards sidebar due date', :js do ...@@ -17,6 +17,8 @@ RSpec.describe 'Project issue boards sidebar due date', :js do
end end
before do before do
stub_feature_flags(graphql_board_lists: false)
project.add_maintainer(user) project.add_maintainer(user)
sign_in(user) sign_in(user)
......
...@@ -18,6 +18,8 @@ RSpec.describe 'Project issue boards sidebar labels', :js do ...@@ -18,6 +18,8 @@ RSpec.describe 'Project issue boards sidebar labels', :js do
let(:card) { find('.board:nth-child(2)').first('.board-card') } let(:card) { find('.board:nth-child(2)').first('.board-card') }
before do before do
stub_feature_flags(graphql_board_lists: false)
project.add_maintainer(user) project.add_maintainer(user)
sign_in(user) sign_in(user)
......
...@@ -16,6 +16,8 @@ RSpec.describe 'Project issue boards sidebar milestones', :js do ...@@ -16,6 +16,8 @@ RSpec.describe 'Project issue boards sidebar milestones', :js do
let(:card2) { find('.board:nth-child(1) .board-card:nth-of-type(2)') } let(:card2) { find('.board:nth-child(1) .board-card:nth-of-type(2)') }
before do before do
stub_feature_flags(graphql_board_lists: false)
project.add_maintainer(user) project.add_maintainer(user)
sign_in(user) sign_in(user)
......
...@@ -13,6 +13,8 @@ RSpec.describe 'Project issue boards sidebar', :js do ...@@ -13,6 +13,8 @@ RSpec.describe 'Project issue boards sidebar', :js do
let(:card) { find('.board:nth-child(1)').first('.board-card') } let(:card) { find('.board:nth-child(1)').first('.board-card') }
before do before do
stub_feature_flags(graphql_board_lists: false)
project.add_maintainer(user) project.add_maintainer(user)
sign_in(user) sign_in(user)
......
...@@ -16,6 +16,8 @@ RSpec.describe 'Project issue boards sidebar subscription', :js do ...@@ -16,6 +16,8 @@ RSpec.describe 'Project issue boards sidebar subscription', :js do
let(:card2) { find('.board:nth-child(1) .board-card:nth-of-type(2)') } let(:card2) { find('.board:nth-child(1) .board-card:nth-of-type(2)') }
before do before do
stub_feature_flags(graphql_board_lists: false)
project.add_maintainer(user) project.add_maintainer(user)
sign_in(user) sign_in(user)
......
...@@ -15,6 +15,8 @@ RSpec.describe 'Project issue boards sidebar time tracking', :js do ...@@ -15,6 +15,8 @@ RSpec.describe 'Project issue boards sidebar time tracking', :js do
let(:application_settings) { {} } let(:application_settings) { {} }
before do before do
stub_feature_flags(graphql_board_lists: false)
project.add_maintainer(user) project.add_maintainer(user)
sign_in(user) sign_in(user)
......
...@@ -21,7 +21,8 @@ RSpec.describe 'Sub-group project issue boards', :js do ...@@ -21,7 +21,8 @@ RSpec.describe 'Sub-group project issue boards', :js do
wait_for_requests wait_for_requests
end end
it 'creates new label from sidebar' do # TODO https://gitlab.com/gitlab-org/gitlab/-/issues/324290
xit 'creates new label from sidebar' do
find('.board-card').click find('.board-card').click
page.within '.labels' do page.within '.labels' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment