Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
eb5cd3f2
Commit
eb5cd3f2
authored
Sep 10, 2019
by
Gabriel Mazetto
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use find_by_id and remove rubocop skip flags
parent
cca4fdf1
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
15 deletions
+3
-15
ee/lib/gitlab/geo/replication/file_downloader.rb
ee/lib/gitlab/geo/replication/file_downloader.rb
+1
-5
ee/lib/gitlab/geo/replication/job_artifact_downloader.rb
ee/lib/gitlab/geo/replication/job_artifact_downloader.rb
+1
-5
ee/lib/gitlab/geo/replication/lfs_downloader.rb
ee/lib/gitlab/geo/replication/lfs_downloader.rb
+1
-5
No files found.
ee/lib/gitlab/geo/replication/file_downloader.rb
View file @
eb5cd3f2
...
...
@@ -24,13 +24,9 @@ module Gitlab
private
# rubocop: disable CodeReuse/ActiveRecord
def
find_resource
Upload
.
find_by
(
id:
object_db_id
)
Upload
.
find_by
_id
(
object_db_id
)
end
# rubocop: enable CodeReuse/ActiveRecord
end
end
end
...
...
ee/lib/gitlab/geo/replication/job_artifact_downloader.rb
View file @
eb5cd3f2
...
...
@@ -19,13 +19,9 @@ module Gitlab
private
# rubocop: disable CodeReuse/ActiveRecord
def
find_resource
::
Ci
::
JobArtifact
.
find_by
(
id:
object_db_id
)
::
Ci
::
JobArtifact
.
find_by
_id
(
object_db_id
)
end
# rubocop: enable CodeReuse/ActiveRecord
end
end
end
...
...
ee/lib/gitlab/geo/replication/lfs_downloader.rb
View file @
eb5cd3f2
...
...
@@ -19,13 +19,9 @@ module Gitlab
private
# rubocop: disable CodeReuse/ActiveRecord
def
find_resource
LfsObject
.
find_by
(
id:
object_db_id
)
LfsObject
.
find_by
_id
(
object_db_id
)
end
# rubocop: enable CodeReuse/ActiveRecord
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment