Merge branch 'mo-add-codequality-backend-beta' into 'master'

Add codequality backend comparison feature flag

See merge request gitlab-org/gitlab!53068

app/assets/javascripts/reports/codequality_report/grouped_codequality_reports_app.vue

@@ -62,7 +62,7 @@ export default {
       helpPath: this.codequalityHelpPath,
     });
 
-    this.fetchReports(this.glFeatures.codequalityMrDiff);
+    this.fetchReports(this.glFeatures.codequalityBackendComparison);
   },
   methods: {
     ...mapActions(['fetchReports', 'setPaths']),

app/controllers/projects/merge_requests_controller.rb

@@ -41,7 +41,7 @@ class Projects::MergeRequestsController < Projects::MergeRequests::ApplicationCo
     push_frontend_feature_flag(:core_security_mr_widget_counts, @project)
     push_frontend_feature_flag(:remove_resolve_note, @project, default_enabled: true)
     push_frontend_feature_flag(:diffs_gradual_load, @project, default_enabled: true)
-    push_frontend_feature_flag(:codequality_mr_diff, @project)
+    push_frontend_feature_flag(:codequality_backend_comparison, @project, default_enabled: :yaml)
     push_frontend_feature_flag(:suggestions_custom_commit, @project)
     push_frontend_feature_flag(:local_file_reviews, default_enabled: :yaml)
     push_frontend_feature_flag(:paginated_notes, @project, default_enabled: :yaml)

app/models/merge_request.rb

@@ -1503,7 +1503,7 @@ class MergeRequest < ApplicationRecord
   end
 
   def has_codequality_reports?
-    return false unless ::Gitlab::Ci::Features.display_quality_on_mr_diff?(project)
+    return false unless ::Gitlab::Ci::Features.display_codequality_backend_comparison?(project)
 
     actual_head_pipeline&.has_reports?(Ci::JobArtifact.codequality_reports)
   end

config/feature_flags/development/codequality_backend_comparison.yml

+---
+name: codequality_backend_comparison
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/53068
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/300796
+milestone: '13.9'
+type: development
+group: group::testing
+default_enabled: false

lib/gitlab/ci/features.rb

@@ -71,6 +71,10 @@ module Gitlab
       def self.display_quality_on_mr_diff?(project)
         ::Feature.enabled?(:codequality_mr_diff, project, default_enabled: false)
       end
+
+      def self.display_codequality_backend_comparison?(project)
+        ::Feature.enabled?(:codequality_backend_comparison, project, default_enabled: :yaml)
+      end
     end
   end
 end

spec/frontend/reports/codequality_report/store/actions_spec.js

@@ -65,7 +65,7 @@ describe('Codequality Reports actions', () => {
     let mock;
     let diffFeatureFlagEnabled;
 
-    describe('with codequalityMrDiff feature flag enabled', () => {
+    describe('with codequalityBackendComparison feature flag enabled', () => {
       beforeEach(() => {
         diffFeatureFlagEnabled = true;
         localState.reportsPath = `${TEST_HOST}/codequality_reports.json`;
@@ -112,7 +112,7 @@ describe('Codequality Reports actions', () => {
       });
     });
 
-    describe('with codequalityMrDiff feature flag disabled', () => {
+    describe('with codequalityBackendComparison feature flag disabled', () => {
       beforeEach(() => {
         diffFeatureFlagEnabled = false;
         localState.headPath = `${TEST_HOST}/head.json`;

spec/models/merge_request_spec.rb

@@ -2022,7 +2022,7 @@ RSpec.describe MergeRequest, factory_default: :keep do
 
       context 'when feature flag is disabled' do
         before do
-          stub_feature_flags(codequality_mr_diff: false)
+          stub_feature_flags(codequality_backend_comparison: false)
         end
 
         it { is_expected.to be_falsey }