Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ebef1a84
Commit
ebef1a84
authored
Dec 02, 2016
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove change to MWBS in code review guideline
[ci skip]
parent
85c4aa4a
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
1 deletion
+1
-1
doc/development/code_review.md
doc/development/code_review.md
+1
-1
No files found.
doc/development/code_review.md
View file @
ebef1a84
...
@@ -70,7 +70,7 @@ experience, refactors the existing code). Then:
...
@@ -70,7 +70,7 @@ experience, refactors the existing code). Then:
-
After a round of line notes, it can be helpful to post a summary note such as
-
After a round of line notes, it can be helpful to post a summary note such as
"LGTM :thumbsup:", or "Just a couple things to address."
"LGTM :thumbsup:", or "Just a couple things to address."
-
Avoid accepting a merge request before the build succeeds. Of course, "Merge
-
Avoid accepting a merge request before the build succeeds. Of course, "Merge
When
Pipeline Succeeds"
is fine.
When
Build Succeeds" (MWBS)
is fine.
-
If you set the MR to "Merge When Build Succeeds", you should take over
-
If you set the MR to "Merge When Build Succeeds", you should take over
subsequent revisions for anything that would be spotted after that.
subsequent revisions for anything that would be spotted after that.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment