Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ec9cbd10
Commit
ec9cbd10
authored
Mar 02, 2021
by
Małgorzata Ksionek
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove feature flag
parent
f8835703
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
0 additions
and
28 deletions
+0
-28
config/feature_flags/development/dynamic_nonce_creation.yml
config/feature_flags/development/dynamic_nonce_creation.yml
+0
-8
spec/lib/gitlab/crypto_helper_spec.rb
spec/lib/gitlab/crypto_helper_spec.rb
+0
-16
spec/models/concerns/token_authenticatable_strategies/encrypted_spec.rb
...ncerns/token_authenticatable_strategies/encrypted_spec.rb
+0
-4
No files found.
config/feature_flags/development/dynamic_nonce_creation.yml
deleted
100644 → 0
View file @
f8835703
---
name
:
dynamic_nonce_creation
introduced_by_url
:
rollout_issue_url
:
milestone
:
'
13.9'
type
:
development
group
:
group::manage
default_enabled
:
false
spec/lib/gitlab/crypto_helper_spec.rb
View file @
ec9cbd10
...
...
@@ -32,10 +32,6 @@ RSpec.describe Gitlab::CryptoHelper do
end
describe
'.aes256_gcm_decrypt'
do
before
do
stub_feature_flags
(
dynamic_nonce_creation:
false
)
end
context
'when token was encrypted using static nonce'
do
let
(
:encrypted
)
{
described_class
.
aes256_gcm_encrypt
(
'some-value'
,
nonce:
described_class
::
AES256_GCM_IV_STATIC
)
}
...
...
@@ -54,18 +50,6 @@ RSpec.describe Gitlab::CryptoHelper do
it
'does not save hashed token with iv value in database'
do
expect
{
described_class
.
aes256_gcm_decrypt
(
encrypted
)
}.
not_to
change
{
TokenWithIv
.
count
}
end
context
'with feature flag switched on'
do
before
do
stub_feature_flags
(
dynamic_nonce_creation:
true
)
end
it
'correctly decrypts encrypted string'
do
decrypted
=
described_class
.
aes256_gcm_decrypt
(
encrypted
)
expect
(
decrypted
).
to
eq
'some-value'
end
end
end
end
end
spec/models/concerns/token_authenticatable_strategies/encrypted_spec.rb
View file @
ec9cbd10
...
...
@@ -68,10 +68,6 @@ RSpec.describe TokenAuthenticatableStrategies::Encrypted do
context
'when using optional strategy'
do
let
(
:options
)
{
{
encrypted: :optional
}
}
before
do
stub_feature_flags
(
dynamic_nonce_creation:
false
)
end
it
'returns decrypted token when an encrypted token is present'
do
allow
(
instance
).
to
receive
(
:read_attribute
)
.
with
(
'some_field_encrypted'
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment