Merge branch '34120-design-system-notes-icon-does-not-appear' into 'master'

Resolve "Design system notes icon does not appear"

Closes #34120

See merge request gitlab-org/gitlab!18693

changelogs/unreleased/34120-design-system-notes-icon-does-not-appear.yml

+---
+title: Resolve missing design system notes icons
+merge_request: 18693
+author:
+type: fixed

ee/app/helpers/ee/system_note_helper.rb

@@ -19,9 +19,9 @@ module EE
       'weight' => 'weight',
       'relate_epic' => 'epic',
       'unrelate_epic' => 'epic',
-      'design_added' => 'doc-image',
-      'design_modified' => 'doc-image',
-      'design_removed' => 'doc-image'
+      'designs_added' => 'doc-image',
+      'designs_modified' => 'doc-image',
+      'designs_removed' => 'doc-image'
     }.freeze
 
     override :system_note_icon_name

ee/spec/services/system_note_service_spec.rb

@@ -99,6 +99,32 @@ describe SystemNoteService do
       end
     end
 
+    describe 'icons' do
+      where(:action) do
+        [
+          [:creation],
+          [:modification],
+          [:deletion]
+        ]
+      end
+
+      with_them do
+        before do
+          version.actions.update_all(event: action)
+        end
+
+        subject(:metadata) do
+          described_class.design_version_added(version)
+            .first.system_note_metadata
+        end
+
+        it 'has a valid action' do
+          expect(EE::SystemNoteHelper::EE_ICON_NAMES_BY_ACTION)
+            .to include(metadata.action)
+        end
+      end
+    end
+
     context 'it succeeds' do
       where(:action, :icon, :human_description) do
         [