Merge branch '276189-enable-vue_epics_list-for-everyone-by-default' into 'master'

Enable `vue_epics_list` by default for all groups

See merge request gitlab-org/gitlab!77850

app/assets/javascripts/vue_shared/issuable/list/components/issuable_item.vue

@@ -193,7 +193,13 @@ export default {
           :title="__('This issue is hidden because its author has been banned')"
           :aria-label="__('Hidden')"
         />
-        <gl-link class="issue-title-text" dir="auto" :href="webUrl" v-bind="issuableTitleProps">
+        <gl-link
+          class="issue-title-text"
+          dir="auto"
+          :href="webUrl"
+          data-qa-selector="issuable_title_link"
+          v-bind="issuableTitleProps"
+        >
           {{ issuable.title }}
           <gl-icon v-if="isIssuableUrlExternal" name="external-link" class="gl-ml-2" />
         </gl-link>

doc/user/group/epics/manage_epics.md

@@ -164,6 +164,7 @@ than 1000. The cached value is rounded to thousands or millions and updated ever
 > - Searching by the user's reaction emoji [introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/325630) in GitLab 13.11.
 > - Sorting by epic titles [introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/331625) in GitLab 14.1.
 > - Searching by milestone and confidentiality [introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/268372) in GitLab 14.2 [with a flag](../../../administration/feature_flags.md) named `vue_epics_list`. Disabled by default.
+> - [Enabled on GitLab.com and self-managed](https://gitlab.com/gitlab-org/gitlab/-/issues/276189) in GitLab 14.7.
 
 You can search for an epic from the list of epics using filtered search bar based on following
 parameters:

ee/app/assets/javascripts/epics_list/components/epics_list_root.vue

@@ -262,9 +262,14 @@ export default {
         @click="showBulkEditSidebar = true"
         >{{ __('Edit epics') }}</gl-button
       >
-      <gl-button v-if="canCreateEpic" category="primary" variant="confirm" :href="epicNewPath">{{
-        __('New epic')
-      }}</gl-button>
+      <gl-button
+        v-if="canCreateEpic"
+        category="primary"
+        variant="confirm"
+        :href="epicNewPath"
+        data-qa-selector="new_epic_button"
+        >{{ __('New epic') }}</gl-button
+      >
     </template>
     <template #bulk-edit-actions="{ checkedIssuables }">
       <gl-button

ee/app/views/groups/epics/index.html.haml

@@ -3,7 +3,7 @@
 - page_title _("Epics")
 - is_signed_in = current_user.present?.to_s
 
-- if Feature.enabled?(:vue_epics_list, @group)
+- if Feature.enabled?(:vue_epics_list, @group, default_enabled: :yaml)
   #js-epics-list{ data: { can_create_epic: can?(current_user, :create_epic, @group).to_s,
     can_bulk_edit_epics: @can_bulk_update.to_s,
     page: params[:page],

config/feature_flags/development/vue_epics_list.yml → ee/config/feature_flags/development/vue_epics_list.yml

@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/276189
 milestone: '13.9'
 type: development
 group: group::product planning
-default_enabled: false
+default_enabled: true

qa/qa/ee/page/group/epic/index.rb

@@ -6,11 +6,11 @@ module QA
       module Group
         module Epic
           class Index < QA::Page::Base
-            view 'ee/app/views/groups/epics/_epic.html.haml' do
-              element :epic_title_text
+            view 'app/assets/javascripts/vue_shared/issuable/list/components/issuable_item.vue' do
+              element :issuable_title_link
             end
 
-            view 'ee/app/views/groups/epics/index.html.haml' do
+            view 'ee/app/assets/javascripts/epics_list/components/epics_list_root.vue' do
               element :new_epic_button
             end
 
@@ -19,13 +19,13 @@ module QA
             end
 
             def click_first_epic(page = nil)
-              all_elements(:epic_title_text, minimum: 1).first.click
+              all_elements(:issuable_title_link, minimum: 1).first.click
               page.validate_elements_present! if page
             end
 
             def has_epic_title?(title)
               wait_until do
-                has_element?(:epic_title_text, text: title)
+                has_element?(:issuable_title_link, text: title)
               end
             end
           end

qa/qa/specs/features/ee/browser_ui/2_plan/epic/promote_issue_to_epic_spec.rb

 # frozen_string_literal: true
 
 module QA
-  RSpec.describe 'Plan', :reliable do
+  # TODO: Remove :requires_admin when the `Runtime::Feature.enable` method call is removed
+  RSpec.describe 'Plan', :reliable, :requires_admin do
     describe 'promote issue to epic' do
-      it 'promotes issue to epic', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347970' do
-        Flow::Login.sign_in
-
-        project = Resource::Project.fabricate_via_api! do |project|
+      let(:project) do
+        Resource::Project.fabricate_via_api! do |project|
           project.name = 'promote-issue-to-epic'
           project.description = 'Project to promote issue to epic'
         end
+      end
 
-        issue = Resource::Issue.fabricate_via_api! do |issue|
+      let(:issue) do
+        Resource::Issue.fabricate_via_api! do |issue|
           issue.project = project
         end
+      end
 
+      before do
+        Runtime::Feature.enable(:vue_epics_list, group: project.group)
+
+        Flow::Login.sign_in
+      end
+
+      it 'promotes issue to epic', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347970' do
         issue.visit!
 
         Page::Project::Issue::Show.perform do |show|